124952 - Remove the "depend->clean" hack

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert (:KaiE:)]

Brian recommended me, I promised him to remove the "depend->clean" hack as soon
as we no longer need it. This hack was checked in with the landing of NSS 3.4,
in order to force a rebuild of NSS on depend machines.
I guess we will need r/sr on the patches to remove the hack, therefore I'm
filing a bug.

Comment 1

[Kai Engert (:KaiE:)]

recommended => reminded :)

Comment 2

[Kai Engert (:KaiE:)]

Attachment: Suggested fix

Comment 3

[Kai Engert (:KaiE:)]

Wan-Teh, can you please review?

Comment 4

[Wan-Teh Chang]

Comment on attachment 69432 [details] [diff] [review]
Suggested fix

mozilla/Makefile.in (at the very end) also needs to
be changed.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: Updated patch

Added change for mozilla/Makefile.in

Comment 6

[Wan-Teh Chang]

Kai,

I checked in your patch and moved the NSS_CLIENT_TAG
on mozilla/security/nss/makefile.win.  I'll let you
mark this bug fixed because I don't know what target
milestone I should set it to.

Comment 7

[Kai Engert (:KaiE:)]

Wan-Teh, thanks for checking it in, marking fixed.

(I think it is fine to leave the target milestone as it is, my understanding is,
it is only required for scheduling purposes. Stephane, Brian, please correct me
if I understood this wrong.)

Comment 8

[John Unruh]

Verified per wtc's comment.