1249528 - releaserunner should handle RC channels

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

For RC builds we generate updates for 2 channels: beta and release. Release runner should pass them properly in http://hg.mozilla.org/build/tools/file/b5d631ae0c09/buildfarm/release/release-runner.py#l312 based on version regexp (r"\d+\.0$") + branch (m-r only).

Comment 1

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

Review commit: https://reviewboard.mozilla.org/r/39719/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39719/

Comment 2

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1249528 - tools: override chunking info r=Callek

Review commit: https://reviewboard.mozilla.org/r/39715/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39715/

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

https://reviewboard.mozilla.org/r/39719/#review36401

::: mozilla/config.py:2725
(Diff revision 1)
>  # used by releasetasks
>  BRANCHES['mozilla-beta']['bouncer_enabled'] = True
>  BRANCHES['mozilla-beta']['postrelease_version_bump_enabled'] = True
>  BRANCHES['mozilla-beta']['push_to_candidates_enabled'] = True
>  BRANCHES['mozilla-beta']['push_to_releases_automatic'] = False
> -BRANCHES['mozilla-beta']['release_channels'] = ("beta",)
> +BRANCHES['mozilla-beta']['release_channel_mappings'] = [["^.*$", ["beta"]]]

it feels clunky to have this match any version pattern ... or str in general :)

but I don't have any other suggestion that would make a big enough difference aside from ship-it supplying a 'RC' or the inverse 'dot release' flag so we don't need to guess with regexes

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8730160 [details]
MozReview Request: Bug 1249528 - tools: override chunking info r=Callek

https://reviewboard.mozilla.org/r/39715/#review36403

Comment 5

[Rail Aliiev [:rail]]

(In reply to Jordan Lund (:jlund) from comment #3)
> it feels clunky to have this match any version pattern ... or str in general
> :)

Yeah... I thought about using str for beta and some mapping for release, but I'm not sure if the code would look better in this case.

> but I don't have any other suggestion that would make a big enough
> difference aside from ship-it supplying a 'RC' or the inverse 'dot release'
> flag so we don't need to guess with regexes

Ship-it v2 FTW! :)

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

https://hg.mozilla.org/build/buildbot-configs/rev/5235b4ceb15e

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

I had to backout this change, because the variable is used in release.py.

Comment 8

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/5235b4ceb15e

Comment 9

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/806fd2074e58

Comment 10

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/fc1e57afc013

Comment 11

[Rail Aliiev [:rail]]

WIP:

Stop using chunks/chunk in the builder name:

  * buildbot-custom patch: https://gist.github.com/rail/6d23e6a4c53a4828f1b7
  * releasetasks patch: https://github.com/mozilla/releasetasks/compare/master...rail:uv_chunks?expand=1
  * tools patch: https://gist.github.com/rail/44bf95404108d87f3bea

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 8730160 [details]
MozReview Request: Bug 1249528 - tools: override chunking info r=Callek

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39715/diff/1-2/

Comment 13

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1249528 - Unify update verify builders r=Callek

Review commit: https://reviewboard.mozilla.org/r/41491/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41491/

Comment 14

[Rail Aliiev [:rail]]

Attachment: configs.diff

Comment 15

[Rail Aliiev [:rail]]

Attachment: tools.diff

Comment 16

[Rail Aliiev [:rail]]

Attachment: PR for releasetasks

Comment 17

[Justin Wood (:Callek)]

Comment on attachment 8733030 [details] [diff] [review]
tools.diff

Review of attachment 8733030 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.py
@@ +94,5 @@
> +    """
> +    for pattern, channels in mappings:
> +        if re.match(pattern, version):
> +            return channels
> +    raise RuntimeError("Cannot find update channels for %s" % version)

As was said elsewhere (I think) I'm not a fan of this, but I don't have a better solution.

Comment 18

[Rail Aliiev [:rail]]

Comment on attachment 8732988 [details]
MozReview Request: Bug 1249528 - Unify update verify builders r=Callek

https://hg.mozilla.org/build/buildbotcustom/rev/139b15174c5d

Comment 19

[Rail Aliiev [:rail]]

Comment on attachment 8733030 [details] [diff] [review]
tools.diff

https://hg.mozilla.org/build/tools/rev/2b4707b2f293

Comment 20

[Rail Aliiev [:rail]]

Comment on attachment 8733029 [details] [diff] [review]
configs.diff

https://hg.mozilla.org/build/buildbot-configs/rev/42e571aa53d8

Comment 21

[Rail Aliiev [:rail]]

Next:
1) reconfig
2) deploy release-runner.py/releasetasks changes

Comment 22

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/42e571aa53d8

Comment 23

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/139b15174c5d

Comment 24

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #21)
> Next:
> 1) reconfig
> 2) deploy release-runner.py/releasetasks changes

These are done. Waiting for the next beta to verify

Comment 25

[Rail Aliiev [:rail]]

A follow up: https://hg.mozilla.org/build/buildbotcustom/rev/40258e329c78

Comment 26

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/40258e329c78