releaserunner should handle RC channels

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

Assignee

Description

3 years ago
For RC builds we generate updates for 2 channels: beta and release. Release runner should pass them properly in http://hg.mozilla.org/build/tools/file/b5d631ae0c09/buildfarm/release/release-runner.py#l312 based on version regexp (r"\d+\.0$") + branch (m-r only).
Assignee

Updated

3 years ago
Assignee: nobody → rail
Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

https://reviewboard.mozilla.org/r/39719/#review36401

::: mozilla/config.py:2725
(Diff revision 1)
>  # used by releasetasks
>  BRANCHES['mozilla-beta']['bouncer_enabled'] = True
>  BRANCHES['mozilla-beta']['postrelease_version_bump_enabled'] = True
>  BRANCHES['mozilla-beta']['push_to_candidates_enabled'] = True
>  BRANCHES['mozilla-beta']['push_to_releases_automatic'] = False
> -BRANCHES['mozilla-beta']['release_channels'] = ("beta",)
> +BRANCHES['mozilla-beta']['release_channel_mappings'] = [["^.*$", ["beta"]]]

it feels clunky to have this match any version pattern ... or str in general :)

but I don't have any other suggestion that would make a big enough difference aside from ship-it supplying a 'RC' or the inverse 'dot release' flag so we don't need to guess with regexes
Attachment #8730158 - Flags: review?(jlund) → review+
Comment on attachment 8730160 [details]
MozReview Request: Bug 1249528 - tools: override chunking info r=Callek

https://reviewboard.mozilla.org/r/39715/#review36403
Attachment #8730160 - Flags: review?(jlund) → review+
Assignee

Comment 5

3 years ago
(In reply to Jordan Lund (:jlund) from comment #3)
> it feels clunky to have this match any version pattern ... or str in general
> :)

Yeah... I thought about using str for beta and some mapping for release, but I'm not sure if the code would look better in this case.

> but I don't have any other suggestion that would make a big enough
> difference aside from ship-it supplying a 'RC' or the inverse 'dot release'
> flag so we don't need to guess with regexes

Ship-it v2 FTW! :)
Assignee

Comment 6

3 years ago
Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

https://hg.mozilla.org/build/buildbot-configs/rev/5235b4ceb15e
Attachment #8730158 - Flags: checked-in+
Assignee

Comment 7

3 years ago
Comment on attachment 8730158 [details]
MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund

I had to backout this change, because the variable is used in release.py.
Attachment #8730158 - Flags: checked-in+ → checked-in-
Assignee

Comment 11

3 years ago
WIP:

Stop using chunks/chunk in the builder name:

  * buildbot-custom patch: https://gist.github.com/rail/6d23e6a4c53a4828f1b7
  * releasetasks patch: https://github.com/mozilla/releasetasks/compare/master...rail:uv_chunks?expand=1
  * tools patch: https://gist.github.com/rail/44bf95404108d87f3bea
Blocks: 1257012
No longer blocks: release-promotion
Assignee

Comment 12

3 years ago
Comment on attachment 8730160 [details]
MozReview Request: Bug 1249528 - tools: override chunking info r=Callek

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39715/diff/1-2/
Attachment #8730160 - Attachment description: MozReview Request: Bug 1249528 - releaserunner should handle RC channels r=jlund → MozReview Request: Bug 1249528 - tools: override chunking info r=Callek
Attachment #8730160 - Flags: review?(bugspam.Callek)
Assignee

Updated

3 years ago
Attachment #8730158 - Attachment is obsolete: true
Assignee

Updated

3 years ago
Attachment #8730160 - Attachment is obsolete: true
Attachment #8730160 - Flags: review?(bugspam.Callek)
Assignee

Comment 14

3 years ago
Posted patch configs.diffSplinter Review
Attachment #8733029 - Flags: review?(bugspam.Callek)
Assignee

Comment 15

3 years ago
Posted patch tools.diffSplinter Review
Attachment #8733030 - Flags: review?(bugspam.Callek)
Assignee

Comment 16

3 years ago
Posted file PR for releasetasks
Attachment #8733031 - Flags: review?(bugspam.Callek)
Comment on attachment 8733030 [details] [diff] [review]
tools.diff

Review of attachment 8733030 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.py
@@ +94,5 @@
> +    """
> +    for pattern, channels in mappings:
> +        if re.match(pattern, version):
> +            return channels
> +    raise RuntimeError("Cannot find update channels for %s" % version)

As was said elsewhere (I think) I'm not a fan of this, but I don't have a better solution.
Attachment #8733030 - Flags: review?(bugspam.Callek) → review+
Attachment #8733029 - Flags: review?(bugspam.Callek) → review+
Attachment #8733031 - Flags: review?(bugspam.Callek) → review+
Attachment #8732988 - Flags: review?(bugspam.Callek) → review+
Assignee

Comment 18

3 years ago
Comment on attachment 8732988 [details]
MozReview Request: Bug 1249528 - Unify update verify builders r=Callek

https://hg.mozilla.org/build/buildbotcustom/rev/139b15174c5d
Attachment #8732988 - Flags: checked-in+
Assignee

Updated

3 years ago
Attachment #8733031 - Flags: checked-in+
Assignee

Comment 21

3 years ago
Next:
1) reconfig
2) deploy release-runner.py/releasetasks changes
Assignee

Comment 24

3 years ago
(In reply to Rail Aliiev [:rail] from comment #21)
> Next:
> 1) reconfig
> 2) deploy release-runner.py/releasetasks changes

These are done. Waiting for the next beta to verify
Assignee

Updated

3 years ago
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.