If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

about:debugging refactor rename components from ThingComponent to Thing

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Developer Tools: about:debugging
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

47 Branch
Firefox 47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
Follow up to Bug 1245029.

As suggested by Jan, we should rename all "ThingComponent" classes to just "Thing", and maybe "{Addons,Workers}" to something like "{Addons,Workers}Tab".
(Assignee)

Updated

2 years ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Depends on: 1245029
(Assignee)

Comment 1

2 years ago
Created attachment 8721804 [details] [diff] [review]
bug1249585.v1.patch

Bug 1249585 - aboutdebugging rename components ThingComponent -> Thing;r=janx

Removed the Component suffix from all aboutdebugging react components.
Renamed WorkersComponent to WorkersTab and AddonsComponent to AddonsTab. 

Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81db36f7aca
Attachment #8721804 - Flags: review?(janx)
(Assignee)

Updated

2 years ago
Blocks: 1250002
(Assignee)

Comment 2

2 years ago
Created attachment 8721807 [details] [diff] [review]
bug1249585.v1.patch (renamed 2 files)

I had forgotten to rename workers.js and addons.js to {name}-tab.js in the previous patch.
Attachment #8721804 - Attachment is obsolete: true
Attachment #8721804 - Flags: review?(janx)
Attachment #8721807 - Flags: review?(janx)

Comment 3

2 years ago
Comment on attachment 8721807 [details] [diff] [review]
bug1249585.v1.patch (renamed 2 files)

Review of attachment 8721807 [details] [diff] [review]:
-----------------------------------------------------------------

Haha, nice bug title :) but maybe change the patch description to something more serious like "Bug 1249585 - Rename about:debugging components s/Component//g. r=janx"?

Otherwise LGTM!
Attachment #8721807 - Flags: review?(janx) → review+
(Assignee)

Comment 4

2 years ago
Created attachment 8721934 [details] [diff] [review]
bug1249585.v2.patch

Carry over r+.

Thanks for the review. FWIW, I didn't intend the commit message to be funny :)
Attachment #8721807 - Attachment is obsolete: true
Attachment #8721934 - Flags: review+
(Assignee)

Comment 5

2 years ago
Try is green as far as devtools jobs are concerned. Pushing to fx-team

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/049eec3c5048

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/049eec3c5048
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.