1249585 - about:debugging refactor rename components from ThingComponent to Thing

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1245029.

As suggested by Jan, we should rename all "ThingComponent" classes to just "Thing", and maybe "{Addons,Workers}" to something like "{Addons,Workers}Tab".

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: bug1249585.v1.patch

Bug 1249585 - aboutdebugging rename components ThingComponent -> Thing;r=janx

Removed the Component suffix from all aboutdebugging react components.
Renamed WorkersComponent to WorkersTab and AddonsComponent to AddonsTab. 

Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81db36f7aca

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: bug1249585.v1.patch (renamed 2 files)

I had forgotten to rename workers.js and addons.js to {name}-tab.js in the previous patch.

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8721807 [details] [diff] [review]
bug1249585.v1.patch (renamed 2 files)

Review of attachment 8721807 [details] [diff] [review]:
-----------------------------------------------------------------

Haha, nice bug title :) but maybe change the patch description to something more serious like "Bug 1249585 - Rename about:debugging components s/Component//g. r=janx"?

Otherwise LGTM!

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: bug1249585.v2.patch

Carry over r+.

Thanks for the review. FWIW, I didn't intend the commit message to be funny :)

Comment 5

[Julian Descottes [:jdescottes]]

Try is green as far as devtools jobs are concerned. Pushing to fx-team

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/049eec3c5048

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/049eec3c5048