1249595 - Enable 11 more ESLint rules for PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

Misc rules that don't require too many changes to turn on, and seem worth the effort enough.

Comment 1

[:Cykesiopka]

10 -> 11 rules because I found another rule that we already pass, and seems worthwhile to have on.

Comment 2

[:Cykesiopka]

Attachment: MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

Review commit: https://reviewboard.mozilla.org/r/36749/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36749/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

https://reviewboard.mozilla.org/r/36749/#review33477

LGTM.

::: security/manager/ssl/tests/unit/head_psm.js:49
(Diff revision 1)
>  const SEC_ERROR_CERT_NOT_IN_NAME_SPACE                  = SEC_ERROR_BASE + 112; // -8080

Why get rid of some of these comments but not others?

Comment 4

[:Cykesiopka]

https://reviewboard.mozilla.org/r/36749/#review33477

Thanks for the review!

> Why get rid of some of these comments but not others?

It was a "while I'm here" thing, but I guess it's better to be consistent. I removed the other comments as well.

Comment 5

[:Cykesiopka]

Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36749/diff/1-2/

Comment 6

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f72a4ea4554

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b8e89af2e6f0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8e89af2e6f0