Enable 11 more ESLint rules for PSM

RESOLVED FIXED in Firefox 47

Status

()

Core
Security: PSM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Misc rules that don't require too many changes to turn on, and seem worth the effort enough.
(Assignee)

Comment 1

2 years ago
10 -> 11 rules because I found another rule that we already pass, and seems worthwhile to have on.
Summary: Enable 10 more ESLint rules for PSM → Enable 11 more ESLint rules for PSM
(Assignee)

Comment 2

2 years ago
Created attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

Review commit: https://reviewboard.mozilla.org/r/36749/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36749/
Attachment #8723829 - Flags: review?(dkeeler)
Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

https://reviewboard.mozilla.org/r/36749/#review33477

LGTM.

::: security/manager/ssl/tests/unit/head_psm.js:49
(Diff revision 1)
>  const SEC_ERROR_CERT_NOT_IN_NAME_SPACE                  = SEC_ERROR_BASE + 112; // -8080

Why get rid of some of these comments but not others?
Attachment #8723829 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/36749/#review33477

Thanks for the review!

> Why get rid of some of these comments but not others?

It was a "while I'm here" thing, but I guess it's better to be consistent. I removed the other comments as well.
(Assignee)

Comment 5

2 years ago
Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36749/diff/1-2/
Attachment #8723829 - Attachment description: MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. → MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler
(Assignee)

Comment 6

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f72a4ea4554
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All

Comment 7

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/b8e89af2e6f0
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b8e89af2e6f0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.