1249601 - wasm: support i64 comparisons

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch adds MCompare support for int64 comparisons and LCompare64/LCompare64AndBranch. It also adds some missing useInt64* methods to Lowering.

This still needs non-x64 codegen and range analysis support. Other than that, the code we generate on x64 should be the same as for int32.

Comment 1

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #0)
> Other than that, the code we generate on x64 should be the same as for int32.

(Well, with movq instead of movl, obviously.)

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8721284 [details] [diff] [review]
Patch

Review of attachment 8721284 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/shared/LIR-shared.h
@@ +2282,5 @@
> +        return CodeName[jsop_];
> +    }
> +};
> +
> +class LCompare64AndBranch : public LControlInstructionHelper<2, 2, 0>

Oops, this should be <2, 2 * BOX_PIECES, 0> (on 64-bit platforms it's equivalent but not on 32-bit).

Comment 3

[Dan Gohman [:sunfish]]

Comment on attachment 8721284 [details] [diff] [review]
Patch

Review of attachment 8721284 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. Int64 support is looking simpler than I had initially pictured. :-)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c167859aa1f5

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c167859aa1f5