1249630 - Distribution.js preferences should handle languages as well as locales

Status: RESOLVED FIXED

(Firefox :: Distributions, defect)

Description

[Mike Kaply [:mkaply]]

Current the distribution architecture only handles locales.

That means if you have a section like:

[LocalizablePreferences-de]

It does not get used if you are on a build with a locale of de-DE. It only gets used if your locale is explcitly de.

We should handle language and locale (with a preference for locale). This will allow us to move to one distribution file for many locales/languages.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: MozReview Request: Bug 1249630 - Add language support to distribution.js; r?mixedpuppy

Review commit: https://reviewboard.mozilla.org/r/35639/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35639/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8721324 [details]
MozReview Request: Bug 1249630 - Add language support to distribution.js; r?mixedpuppy

https://reviewboard.mozilla.org/r/35639/#review32293

Comment 3

[Shane Caraveo (:mixedpuppy)]

because the repack system doesnt use tags or branches for versioning against firefox, we cannot combine the repack locale builds until this changes makes its way into release.  We should get this uplifted to aurora to shorten the wait.

Comment 4

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/fx-team/rev/8b65dd9aa149cd88bb39e6eddfa47a5ed8705055
Bug 1249630 - Add language support to distribution.js; r=mixedpuppy

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8b65dd9aa149