1249659 - Disable accelerated Canvas on OS X versions < 10.8

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

From bug 1246633 and https://www.reddit.com/r/firefox/comments/45yhbm/4402_graphics_glitches_and_hanging_after_half_an - it looks like accelerated skia canvas on 10.7 is still bad. Disable it on anything less than 10.8

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Disable accelerated canvas on OS X less than Mountain Lion

Comment 2

[Mason Chang [Inactive] [:mchang]]

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b29654ea32e

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3389cf88c5

Comment 4

[Mason Chang [Inactive] [:mchang]]

Reminder to uplift after landing

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d3389cf88c5

Comment 6

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Approval Request Comment
[Feature/regressing bug #]: Accelerated Skia GL on OS X on Mac
[User impact if declined]: Flickering on some users hardware, see bug 1246633.
[Describe test coverage new/current, TreeHerder]: Manual 
[Risks and why]: Low - This disables accelerated Skia on OS X less than 10.8. This was the behavior before Gecko 44.
[String/UUID change made/needed]: None

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking affected for current versions.

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Revert to pre-44 behavior for older versions of OS X. 
Sounds better for users than the reported flickering problems.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/83b6cc7ed8e0

Comment 11

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

See comment 6.

Only uplift if bug 1249312 also gets uplifted please.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Lame cc from bug 1249312

I am very unhappy to see this kind of uplift request that late in the cycle.
Next time, please be on top of your features, Bug 1244569 has been reported a month ago :/
Taking it for the only reason that 45 is an ESR.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/48e0d09b052c