Closed Bug 1249659 Opened 4 years ago Closed 4 years ago

Disable accelerated Canvas on OS X versions < 10.8

Categories

(Core :: Graphics, defect, major)

Product:
Core
Component:
Graphics
Version:
44 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox44 --- wontfix
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

Disable accelerated canvas on OS X less than Mountain Lion
1.01 KB, patch
milan
: review+
lizzard
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
From bug 1246633 and https://www.reddit.com/r/firefox/comments/45yhbm/4402_graphics_glitches_and_hanging_after_half_an - it looks like accelerated skia canvas on 10.7 is still bad. Disable it on anything less than 10.8
Attachment #8721350 - Flags: review?(milan) → review+
Blocks: 1246633
Reminder to uplift after landing
Flags: needinfo?(mchang)
https://hg.mozilla.org/mozilla-central/rev/4d3389cf88c5
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Approval Request Comment
[Feature/regressing bug #]: Accelerated Skia GL on OS X on Mac
[User impact if declined]: Flickering on some users hardware, see bug 1246633.
[Describe test coverage new/current, TreeHerder]: Manual 
[Risks and why]: Low - This disables accelerated Skia on OS X less than 10.8. This was the behavior before Gecko 44.
[String/UUID change made/needed]: None
Attachment #8721350 - Flags: approval-mozilla-aurora?
Duplicate of this bug: 1246633
Marking affected for current versions.
status-firefox44: --- → wontfix
status-firefox45: --- → affected
status-firefox46: --- → affected
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Revert to pre-44 behavior for older versions of OS X. 
Sounds better for users than the reported flickering problems.
Attachment #8721350 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

See comment 6.

Only uplift if bug 1249312 also gets uplifted please.
Flags: needinfo?(mchang)
Attachment #8721350 - Flags: approval-mozilla-beta?
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion

Lame cc from bug 1249312

I am very unhappy to see this kind of uplift request that late in the cycle.
Next time, please be on top of your features, Bug 1244569 has been reported a month ago :/
Taking it for the only reason that 45 is an ESR.
Attachment #8721350 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.