Closed
Bug 1249659
Opened 9 years ago
Closed 9 years ago
Disable accelerated Canvas on OS X versions < 10.8
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: mchang, Assigned: mchang)
References
Details
(Whiteboard: gfx-noted)
Attachments
(1 file)
1.01 KB,
patch
|
milan
:
review+
lizzard
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
From bug 1246633 and https://www.reddit.com/r/firefox/comments/45yhbm/4402_graphics_glitches_and_hanging_after_half_an - it looks like accelerated skia canvas on 10.7 is still bad. Disable it on anything less than 10.8
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8721350 -
Flags: review?(milan)
Updated•9 years ago
|
Attachment #8721350 -
Flags: review?(milan) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b29654ea32e
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion
Approval Request Comment
[Feature/regressing bug #]: Accelerated Skia GL on OS X on Mac
[User impact if declined]: Flickering on some users hardware, see bug 1246633.
[Describe test coverage new/current, TreeHerder]: Manual
[Risks and why]: Low - This disables accelerated Skia on OS X less than 10.8. This was the behavior before Gecko 44.
[String/UUID change made/needed]: None
Attachment #8721350 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Marking affected for current versions.
Comment 9•9 years ago
|
||
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion
Revert to pre-44 behavior for older versions of OS X.
Sounds better for users than the reported flickering problems.
Attachment #8721350 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion
See comment 6.
Only uplift if bug 1249312 also gets uplifted please.
Flags: needinfo?(mchang)
Attachment #8721350 -
Flags: approval-mozilla-beta?
Comment 12•9 years ago
|
||
Comment on attachment 8721350 [details] [diff] [review]
Disable accelerated canvas on OS X less than Mountain Lion
Lame cc from bug 1249312
I am very unhappy to see this kind of uplift request that late in the cycle.
Next time, please be on top of your features, Bug 1244569 has been reported a month ago :/
Taking it for the only reason that 45 is an ESR.
Attachment #8721350 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•9 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•