Login UI hiccups caused by redisplaying list unnecessarily

NEW
Unassigned

Status

()

Firefox for iOS
Login Management
P3
normal
Rank:
5
2 years ago
5 months ago

People

(Reporter: rfeeley, Unassigned, NeedInfo)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [papercut][PasswordManager])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8721440 [details]
loading.png

Return to the list from a login is too slow to load. Looks like web content.

Updated

2 years ago
tracking-fxios: --- → ?
Rank: 5
tracking-fxios: ? → 4.0+
Is there a neat test profile I can use for profiling this?
Flags: needinfo?(rnewman)
I don't have one, but Kevin or Aaron might have a test FxA you can sign in to. Failing that, synthesize 400 with random domains and usernames…
Flags: needinfo?(rnewman)
tracking-fxios: 4.0+ → +
(Reporter)

Updated

2 years ago
Component: General → Login Management
Simon, can you find the limitations to where this list becomes slow? (e.g. 500, 1000)
Flags: needinfo?(simion.basca)
Priority: -- → P3
Whiteboard: [papercut]
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Iteration: --- → 1.25
Assigning to myself. We need a script to generate a bunch of fake logins to perf test.
Even without a script to generate test data, it's probably worth verifying with EXPLAIN that both branches of the UNION ALL are making use of the two indices we have for that table.

(Beyond that, it'd be nice if we didn't construct a Login for every row of the table view… darn OO.)

Updated

6 months ago
Whiteboard: [papercut] → [papercut][PasswordManager]
I have 750 saved logins, and on a 6S the list loads fast enough that the only delay is a visual hiccup when adding and removing the spinner! Ryan, is this still bad for you?
Flags: needinfo?(rfeeley)
(Reporter)

Comment 7

6 months ago
Loads fast for me now. The only hiccup I see if when I tap in and out of the search box.
Flags: needinfo?(rfeeley)
Morphing the bug to be "be smoove".
Summary: Logins slow to load → Login UI hiccups caused by redisplaying list unnecessarily
Assignee: jdarcangelo → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.