1249838 - Avoid dependency from the mozconfig loader on mach

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For python configure, I don't want running configure --help to require the virtualenv to be setup. Also, it's better if the configure bootstrap (before it re-executes in virtualenv) doesn't need more than mozbuild.

The mozconfig loader uses ProcessExecutionMixin for _normalize_command, which is relatively trivial, but also turns out we can do better by not using it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1249838 - Avoid dependency from the mozconfig loader on mach

Review commit: https://reviewboard.mozilla.org/r/35721/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35721/

Comment 2

[Gregory Szorc [:gps]]

FWIW, my adding the virtualenv to configure was just the logical place to do it back in the day. That was when people were using client.mk to build (maybe) and mach was in its infancy. I've wanted to make virtualenv creation part of mach command dispatch for a while. See bug 985141. If it were easy it would have been done already :/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8721567 [details]
MozReview Request: Bug 1249838 - Avoid dependency from the mozconfig loader on mach

https://reviewboard.mozilla.org/r/35721/#review32377

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5cb7c366d84

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b5cb7c366d84