Closed Bug 1249838 Opened 5 years ago Closed 5 years ago
Avoid dependency from the mozconfig loader on mach
58 bytes, text/x-review-board-request
For python configure, I don't want running configure --help to require the virtualenv to be setup. Also, it's better if the configure bootstrap (before it re-executes in virtualenv) doesn't need more than mozbuild. The mozconfig loader uses ProcessExecutionMixin for _normalize_command, which is relatively trivial, but also turns out we can do better by not using it.
Summary: Avoid dependency from the mozconfig loader on mac → Avoid dependency from the mozconfig loader on mach
Review commit: https://reviewboard.mozilla.org/r/35721/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/35721/
Attachment #8721567 - Flags: review?(gps)
FWIW, my adding the virtualenv to configure was just the logical place to do it back in the day. That was when people were using client.mk to build (maybe) and mach was in its infancy. I've wanted to make virtualenv creation part of mach command dispatch for a while. See bug 985141. If it were easy it would have been done already :/
Comment on attachment 8721567 [details] MozReview Request: Bug 1249838 - Avoid dependency from the mozconfig loader on mach https://reviewboard.mozilla.org/r/35721/#review32377
Attachment #8721567 - Flags: review?(gps) → review+
You need to log in before you can comment on or make changes to this bug.