devirtualize CanHaveAnonymousChildren

RESOLVED FIXED in Firefox 47

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8721715 [details] [diff] [review]
patch
Attachment #8721715 - Flags: review?(dbolter)
Summary: devirtualize CanHavaAnonymousChildren → devirtualize CanHaveAnonymousChildren
Comment on attachment 8721715 [details] [diff] [review]
patch

Review of attachment 8721715 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. I'd say it is less pretty to read but optimizing TreeWalker is probably a good enough reason.

::: accessible/generic/Accessible.h
@@ +1021,5 @@
>      eSubtreeMutating = 1 << 6, // subtree is being mutated
>      eIgnoreDOMUIEvent = 1 << 7, // don't process DOM UI events for a11y events
>      eSurvivingInUpdate = 1 << 8, // parent drops children to recollect them
>      eRelocated = 1 << 9, // accessible was moved in tree
> +    eNoXBLKids = 1 << 10, // accessible don't allows XBL children

nit: please change the comment to:
"don't allow XBL children", or
"accessible does not allow XBL children"
Attachment #8721715 - Flags: review?(dbolter) → review+
Assignee: nobody → surkov.alexander

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e301a8b9efe
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.