Closed
Bug 1249961
Opened 8 years ago
Closed 8 years ago
Rename MacroAssembler::branchEqualTypeIfNeeded.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
4.42 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
separated from bug 1245112 comment #49. (In reply to Nicolas B. Pierron [:nbp] from bug 1245112 comment #49) > ::: js/src/jit/MacroAssembler.cpp > @@ +2507,5 @@ > > +} > > + > > +void > > +MacroAssembler::branchEqualTypeIfNeeded(MIRType type, MDefinition* maybeDef, Register tag, > > + Label* label) > > follow-up: What do you think about renaming this function > maybeBranchTestType, or something similar? I agree to renaming, as maybe{SOMETHING} is used more often than {SOMETHING}IfNeeded in js/src/jit.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → arai.unmht
Attachment #8726577 -
Flags: review?(nicolas.b.pierron)
Updated•8 years ago
|
Attachment #8726577 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a0c251cdf000a15492e021c75e8aac778f54648 Bug 1249961 - Rename MacroAssembler::branchEqualTypeIfNeeded to MacroAssembler::maybeBranchTestType. r=nbp
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a0c251cdf00
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•