1249967 - Responsive mode links in @media sidebar only resize the viewport if Responsive mode has been launched

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect)

Description

[Tim Nguyen :ntim]

STR:
- Open the Style Editor, *don't* open the responsive mode
- Open about:welcomeback
- Click the link the appears in the @media sidebar
- The viewport resizes to the wrong width, it only properly resizes upon second click

Comment 1

[Tim Nguyen :ntim]

Seems like my test isn't strong enough: https://dxr.mozilla.org/mozilla-central/source/devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js

Comment 2

[Tim Nguyen :ntim]

[Tracking Requested - why for this release]: regression

Comment 3

[Tim Nguyen :ntim]

Attachment: MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

Review commit: https://reviewboard.mozilla.org/r/35777/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35777/

Comment 4

[Tim Nguyen :ntim]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=713965d0cacf

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35777/diff/1-2/

Comment 6

[Tim Nguyen :ntim]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1357c6d184cf

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

https://reviewboard.mozilla.org/r/35777/#review32557

I feel like I tried this during my large test changeset, and then revert for some reason...  anyway, seems fine assuming the tests pass.

::: devtools/client/responsivedesign/responsivedesign.jsm:66
(Diff revision 2)
>     */

Describe the new return value.

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

https://reviewboard.mozilla.org/r/35777/#review32881

Looks fine to me

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35777/diff/2-3/

Comment 10

[Tim Nguyen :ntim]

Rare purely green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17b8acfbfbbe

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8ce7a3436936

Comment 12

[Tim Nguyen :ntim]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

Approval Request Comment
[Feature/regressing bug #]: Bug 1239562
[User impact if declined]: Responsive mode links in the Style Editor @media sidebar will partially work
[Describe test coverage new/current, TreeHerder]: Will be in Nightly, tested locally
[Risks and why]: low, straightforward code changes.
[String/UUID change made/needed]: None

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ce7a3436936

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Regression, tracking for 46+

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8721778 [details]
MozReview Request: Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins

Fix for responsive design tool regressions in 46.

Comment 16

[Carsten Book [:Tomcat]]

has problems uplifting

grafting 330638:8ce7a3436936 "Bug 1249967 - Make @media sidebar links resize the Responsive mode even if it wasn't launched. r=jryans, bgrins"
merging devtools/client/responsivedesign/responsivedesign.jsm
merging devtools/client/styleeditor/StyleEditorUI.jsm
merging devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js
warning: conflicts while merging devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Comment 17

[Tim Nguyen :ntim]

bgrins is on PTO until the merge date, so redirecting to jryans.

Comment 18

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc8bba6da2ed

Comment 19

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Yes, in first click it gives desired size as mentioned in @media rules

Actual Results: 
As expected