Closed
Bug 1249972
Opened 8 years ago
Closed 8 years ago
mozmake installer broken after Bug 1229626 AddTaskbarSC Variable missing
Categories
(SeaMonkey :: Installer, defect)
Tracking
(seamonkey2.44 fixed)
RESOLVED
FIXED
seamonkey2.44
| Tracking | Status | |
|---|---|---|
| seamonkey2.44 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file, 1 obsolete file)
|
7.77 KB,
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
mozmake installer aborts with an error after Bug 1229626 added a AddTaskbarSC variable.
|
Assignee | |
Comment 1•8 years ago
|
||
Adds the missing AddTaskbarSC variable. The installer still does not add Seamonkey to the Start menu or taskbar. Further changes would be needed for this but this is as it was before. Verified against 2.43a2. Tested on Windows with en-US VS2015 builds under x86 XP and 10 and x64 7: User agent: Mozilla/5.0 (Windows NT 5.1; rv:47.0) Gecko/20100101 Firefox/47.0 SeaMonkey/2.44a1 User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0 SeaMonkey/2.44a1
Attachment #8721773 -
Flags: review?(philip.chee)
|
|
||
Updated•8 years ago
|
Attachment #8721773 -
Flags: review?(philip.chee) → review?(bugzilla)
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8721773 [details] [diff] [review] 1249972-AddTaskbarSC_Variable.patch > +; Default for creating Task Bar shortcuts Wrong indentation in above line. > + ; (1 = create, 0 = don't create) > + ${If} $AddTaskbarSC == "" > + StrCpy $AddTaskbarSC "1" > + ${EndIf}
Attachment #8721773 -
Flags: feedback+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Whoops. Thanks. Fixed the indentation
Attachment #8721773 -
Attachment is obsolete: true
Attachment #8721773 -
Flags: review?(bugzilla)
Attachment #8722018 -
Flags: review?(bugzilla)
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8722018 [details] [diff] [review] AddTaskbarSC variable patch rs=me bustage fix
Attachment #8722018 -
Flags: review?(bugzilla) → review+
|
|
||
Comment 5•8 years ago
|
||
Forgot to close this bug: http://hg.mozilla.org/comm-central/rev/7550f71d7383
Status: NEW → RESOLVED
Closed: 8 years ago
status-seamonkey2.44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.44
You need to log in
before you can comment on or make changes to this bug.
Description
•