1250046 - Remove out-of-date Shumway version

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Chris Peterson [:cpeterson]]

The version of Shumway in mozilla-central is out-of-date. We should remove the in-tree snapshot. People interested in testing Shumway can install the latest add-on build from GitHub:

https://github.com/mozilla/shumway/

Comment 1

[Yury Delendik (:yury)]

Attachment: 1. Remove Shumway core files.

Mostly based on bug 904346

Comment 2

[Yury Delendik (:yury)]

Attachment: 2. Remove Shumway references from IPC.

Based on bug 1128768 attachment 8569540 [details] [diff] [review]

Comment 3

[Yury Delendik (:yury)]

Attachment: 3. Remove Shumway references from telemetry.

Removes all SHUMWAY_ entries from historgrams.json and also fixed some docs.

(P.S. https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02aae369da7)

Comment 4

[Till Schneidereit [:till]]

Comment on attachment 8722793 [details] [diff] [review]
1. Remove Shumway core files.

Review of attachment 8722793 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with a few tears shed :(

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8722795 [details] [diff] [review]
3. Remove Shumway references from telemetry.

Review of attachment 8722795 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/bucket-whitelist.json
@@ -44,5 @@
>    "UPDATE_STATUS_ERROR_CODE_PARTIAL_STAGE",
>    "UPDATE_STATUS_ERROR_CODE_UNKNOWN_STAGE",
>    "SECURITY_UI",
>    "CRASH_STORE_COMPRESSED_BYTES",
> -  "SHUMWAY_FEATURE_USED",

Note that you might have landing-conflicts with bug 1219768, which would just mean removing some more Shumway whitelisting here.

Comment 6

[Yury Delendik (:yury)]

Attachment: 3. Remove Shumway references from telemetry.

(In reply to Georg Fritzsche [:gfritzsche] from comment #5)
> Comment on attachment 8722795 [details] [diff] [review]
> 3. Remove Shumway references from telemetry.
> 
> Review of attachment 8722795 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/telemetry/bucket-whitelist.json
> @@ -44,5 @@
> >    "UPDATE_STATUS_ERROR_CODE_PARTIAL_STAGE",
> >    "UPDATE_STATUS_ERROR_CODE_UNKNOWN_STAGE",
> >    "SECURITY_UI",
> >    "CRASH_STORE_COMPRESSED_BYTES",
> > -  "SHUMWAY_FEATURE_USED",
> 
> Note that you might have landing-conflicts with bug 1219768, which would
> just mean removing some more Shumway whitelisting here.

Removed more SHUMWAY_ entries from toolkit/components/telemetry/histogram-whitelists.json after bug 1219768 was landed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a94cc3c2d7c4

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/db53d609ea3d
https://hg.mozilla.org/integration/fx-team/rev/cfb5ae2be5f1
https://hg.mozilla.org/integration/fx-team/rev/b0f74770edc6

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db53d609ea3d
https://hg.mozilla.org/mozilla-central/rev/cfb5ae2be5f1
https://hg.mozilla.org/mozilla-central/rev/b0f74770edc6

Comment 9

[Joel Maher ( :jmaher ) (UTC -0800)]

by removing this we are causing TART timeouts on winxp e10s now:
https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-searchStr=talos%20svg%20xp%20e10s&tochange=952e06e0b849&fromchange=5e6d66db9b05

previously we have had a constant issue with tart on linux64, now this removal has kept linux64 as problematic and added winxp to the list.

:mconley, as one of the owners of TART, do you have any thoughts why removing Shumway might be causing TART crashes?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

(In reply to Joel Maher (:jmaher) from comment #9)
> by removing this we are causing TART timeouts on winxp e10s now:
> https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-
> searchStr=talos%20svg%20xp%20e10s&tochange=952e06e0b849&fromchange=5e6d66db9b
> 05
> 
> previously we have had a constant issue with tart on linux64, now this
> removal has kept linux64 as problematic and added winxp to the list.
> 
> :mconley, as one of the owners of TART, do you have any thoughts why
> removing Shumway might be causing TART crashes?

I can only speculate, but I'm guessing there's some time sensitivity to TART that's not well understood. Removing such a large swath of code probably changed the amount of time it takes to start up a window or a tab, and that's affecting the test.