1250080 - The RDM can't be closed if it's opened in a new tab

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Mihai Boldan, QA [:mboldan]]

[Note]:
- Logged bug based on Bug 1239437 Comment 50 

[Affected versions]:
Firefox 47.0a1 (2016-02-21)

[Affected platforms]:
WIndows 10 x86, Ubuntu 14.04 x86, Mac OS X 10.9.5

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Open a new tab (Ctrl + T).
4. Open the RDM.
5. Close the RDM using the 'Responsive Design View' button from the Menu, or by using the keyboard shortcut.

[Expected result]:
The RDM is closed and the new tab page is correctly displayed.

[Actual result]:
Nothing happens.

[Additional notes]:
If the close command is used for the second time, both RDM page and the new tab page are blank.

Comment 1

[Mihai Boldan, QA [:mboldan]]

[Regression range]:
- This is not a regression since this is a new implementation.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This may get resolved as part of bug 1240900.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi JRyans, this is a new regression in Fx47 and I don't see any activity on bug 1240900. Do we have a patch in the works to address this issue in Aurora 47? Thanks!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Ritu Kothari (:ritu) from comment #3)
> Hi JRyans, this is a new regression in Fx47 and I don't see any activity on
> bug 1240900. Do we have a patch in the works to address this issue in Aurora
> 47? Thanks!

This is for a new feature that is disabled by default, so nothing is needed in 47.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> (In reply to Ritu Kothari (:ritu) from comment #3)
> > Hi JRyans, this is a new regression in Fx47 and I don't see any activity on
> > bug 1240900. Do we have a patch in the works to address this issue in Aurora
> > 47? Thanks!
> 
> This is for a new feature that is disabled by default, so nothing is needed
> in 47.

Thanks Ryan. I have noticed at least 3 other bugs filed w.r.t RDM. I will update those with status-firefox47=disabled.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This issue is "fixed" in the sense that you can't open RDM on a new tab anymore (since it's non-remote).  Bug 1274032 will clarify this by adding a user visible error message.