Closed Bug 1250144 Opened 4 years ago Closed 4 years ago

[Static Analysis][Missing call to superclass] In function ToolbarEditLayout::onAttachedToWindow

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 123515)

Attachments

(1 file)

The Static Analysis tool Coverity added a missing call to superclass was detected in  ToolbarEditLayout::onAttachedToWindow, by this parent  onAttachedToWindow doesn't get called.
Attachment #8721989 - Flags: review?(s.kaspari)
Duplicate of this bug: 1250208
Comment on attachment 8721989 [details]
MozReview Request: Bug 1250144 - call super.onAttachedToWindow in  ToolbarEditLayout::onAttachedToWindow. r?mfinkle

https://reviewboard.mozilla.org/r/35823/#review32495

LGTM.
Attachment #8721989 - Flags: review?(s.kaspari) → review+
Hey Andi-Bogdan.

I've been receiving notifications for new coverity defects and it seems you have been too – will you take care of triaging and filing new bugs for these notifications or is this something that I should continue to look into?
Flags: needinfo?(bogdan.postelnicu)
Hello Michael,

I can take care of triaging and adding patches to the ones that are actually bugs. I hope it's ok if i will forward directly to you or Sebastin review requests.

THX
Flags: needinfo?(bogdan.postelnicu)
Comment on attachment 8721989 [details]
MozReview Request: Bug 1250144 - call super.onAttachedToWindow in  ToolbarEditLayout::onAttachedToWindow. r?mfinkle

Thanks, Sebastian
Attachment #8721989 - Flags: review?(mark.finkle)
https://hg.mozilla.org/mozilla-central/rev/329862bf3499
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.