wasm: support i64 bitwise operators

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Posted patch PatchSplinter Review
The attached patch adds i64.{and,or,xor,shl,shr_s,shr_u}.

x86 is annoying because it has this quirk where it wants non-constant shift amounts in ecx. Then I realized we only care about the lower 32-bits (since we mask it with 0x3f anyway), so LShiftI64 will have a single RHS operand on all platforms (and it will be in ecx on x86 and x64).
Attachment #8721995 - Flags: review?(luke)
Comment on attachment 8721995 [details] [diff] [review]
Patch

Review of attachment 8721995 [details] [diff] [review]:
-----------------------------------------------------------------

Great!  Neat to see how Register64 is used.
Attachment #8721995 - Flags: review?(luke) → review+

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6f7d0257dc2e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.