Closed
Bug 1250165
Opened 8 years ago
Closed 8 years ago
wasm: support i64 bitwise operators
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
60.71 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The attached patch adds i64.{and,or,xor,shl,shr_s,shr_u}.
x86 is annoying because it has this quirk where it wants non-constant shift amounts in ecx. Then I realized we only care about the lower 32-bits (since we mask it with 0x3f anyway), so LShiftI64 will have a single RHS operand on all platforms (and it will be in ecx on x86 and x64).
Attachment #8721995 -
Flags: review?(luke)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8721995 [details] [diff] [review] Patch Review of attachment 8721995 [details] [diff] [review]: ----------------------------------------------------------------- Great! Neat to see how Register64 is used.
Attachment #8721995 -
Flags: review?(luke) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6f7d0257dc2e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•