Errors running eslint on rebase

RESOLVED INCOMPLETE

Status

RESOLVED INCOMPLETE
3 years ago
5 months ago

People

(Reporter: mossop, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
Mak reported an error when rebasing a change with the eslint hook enabled:

[Error 2] Impossibile trovare il file specificato
(unable to find the specified file)

Specifically he was rebasing a small change (135340a254f4) from 194f52b4d779 to 3b17489c9d98.

I suspect this has something to do with the working directory being in an inconsistent state during the rebase commits. The hook assumes the working directory is the code we want to check but I don't know if rebasing updates the working directory in that way.

We might want to just ignore rebases in the hook or instead make sure we get the actual file to check from hg rather than assuming the one in the working directory is correct.
Component: General → ESLint
I haven't heard about any significant issues with rebase & hooks recently, I think I'll resolve this as incomplete, if anyone still has an issue, please re-open & describe in detail.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE

Updated

5 months ago
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.