1250254 - Enable ESLint "no-throw-literal" rule for PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

See Bug 1246594 comment 0 for why doing this is beneficial.

tl;dr: |throw new Error("Foo")| will provide actual line numbers!

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: Bug 1250254 - Enable ESLint "no-throw-literal" rule for PSM.

Review commit: https://reviewboard.mozilla.org/r/37339/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37339/

Comment 2

[:Cykesiopka]

https://reviewboard.mozilla.org/r/37339/#review33891

A few notes:
 - See Bug 1251003 comment 0 for why the .eslintrc -> .eslintrc.json rename was done.
 - ESLint doesn't actually catch something like |throw Cr.NS_ERROR_FAILURE|, maybe because it can't tell NS_ERROR_FAILURE is basically a number.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8725115 [details]
MozReview Request: Bug 1250254 - Enable ESLint "no-throw-literal" rule for PSM.

https://reviewboard.mozilla.org/r/37339/#review34235

LGTM.

::: security/manager/tools/genHPKPStaticPins.js:129
(Diff revision 1)
> -    throw `ERROR: problem downloading '${filename}': status ${req.status}`;
> +    throw new Error("ERROR: problem downloading '" + filename + "': status " +

I'm assuming the switch from template strings is because of line length?

Comment 4

[:Cykesiopka]

https://reviewboard.mozilla.org/r/37339/#review34235

Thanks!

> I'm assuming the switch from template strings is because of line length?

Yes. Sadly there doesn't seem to be a way to have a multi-line template literal ignore inner whitespace without using a tag function or something.

Comment 5

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a1cec792f5

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b670d8ff99ca

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b670d8ff99ca