Closed Bug 1250266 Opened 5 years ago Closed 5 years ago

Always send a TTL in the Push mochitests

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch 322578.patch (obsolete) — Splinter Review
Attachment #8722128 - Flags: review?(bbangert)
Attached patch 322582.patchSplinter Review
While I'm here...let's use POST instead of PUT, and forward the status code that the server sends.
Attachment #8722128 - Attachment is obsolete: true
Attachment #8722128 - Flags: review?(bbangert)
Attachment #8722129 - Flags: review?(bbangert)
Comment on attachment 8722129 [details] [diff] [review]
322582.patch

Review of attachment 8722129 [details] [diff] [review]:
-----------------------------------------------------------------

Technically this looks fine to me, I can't speak to style and such.
Attachment #8722129 - Flags: review?(bbangert) → review+
Blocks: 1250547
https://hg.mozilla.org/mozilla-central/rev/c2d7c361bc95
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.