Tab and Shift+Tab don't work on some pages with contenteditable elements (~a11y)

NEW
Unassigned
(NeedInfo from)

Status

()

3 years ago
2 years ago

People

(Reporter: arni2033, Unassigned, NeedInfo)

Tracking

(Depends on: 1 bug, {regression})

Trunk
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 wontfix, firefox48 wontfix, firefox49 wontfix, firefox50 fix-optional, firefox51 fix-optional)

Details

(Whiteboard: btpp-followup-2016-03-03, URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8722206 [details]
testcase 1 - Tab and Shift+Tab don't work.htm

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160222030212
STR:
1.A) Shift+MiddleClick on the "testcase 1" above to open url in a new tab and switch to it
1.B) Copy url of attached "testcase 1", then open new tab, press Ctrl+L, Ctrl+V, Enter
1.C) [access] press Ctrl+F, type "testcase 1 - ", press Enter several times to find the first string
     on the page, then press Escape, then press Ctrl+Shift+Enter to open link in a new foreground tab
2. Press Tab 10 times
3. Press Shift+Tab 10 times

AR:  Steps 2 and 3 - No visible action.
ER:  Focus should cycle between contenteditable element, selected <tab>, urlbar, searchbar and <html>

This is regression from bug 669026. Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c5b90ea7e475&tochange=f63a99195987

Notes:
1) Scenario (B) also happens with the following "data:" url:
    data:text/html,<span contenteditable>they're taking the beta-testers to Isengard</span>

2) I already filed bug 1248186 which was also broken by bug 669026. I found this bug and
   1248186 separately, and I'm not sure if they were triggered by the same lines of code.
(Reporter)

Updated

3 years ago
Blocks: 669026
Keywords: regression
Whiteboard: btpp-followup-2016-03-03

Comment 1

2 years ago
This is pretty bad, we need an owner here.
status-firefox47: affected → wontfix
status-firefox48: --- → affected
Flags: needinfo?(bugs)
The a11y impact of this one makes me prioritize this higher than other contenteditable bugs.
(In reply to arni2033 from comment #0)
> 1.C) [access] press Ctrl+F, type "testcase 1 - ", press Enter several times
> to find the first string
>      on the page, then press Escape, then press Ctrl+Shift+Enter to open
> link in a new foreground tab

I'm probably missing something obvious, but when I press Ctrl+F, it only searches the text in the page, so typing "testcase 1 -" doesn't find anything.
Depends on: 1277113
Flags: needinfo?(bugs)
status-firefox48: affected → wontfix
status-firefox49: --- → affected
status-firefox50: --- → affected
Another regression from 2011, we don't seem to have a lot of dupes here. We aren't going to keep tracking this in triage.
status-firefox49: affected → wontfix
status-firefox50: affected → fix-optional
status-firefox51: --- → fix-optional
(In reply to :Aryeh Gregor (working until September 2) from comment #3)
> I'm probably missing something obvious, but when I press Ctrl+F, it only
> searches the text in the page, so typing "testcase 1 -" doesn't find
> anything.

Just to clarify, I may be able to work on this bug, but I currently cannot reproduce the issue because I don't understand the STR.  Please clarify the instructions if you want me to take a look at this.
Flags: needinfo?(arni2033)
(Reporter)

Comment 6

2 years ago
STR_2:
1. Shift+MiddleClick on this link: attachment 8722206 [details]
2. Press Tab 10 times
3. Press Shift+Tab 10 times

AR:  Steps 2 and 3 - No visible action.
ER:  Focus should cycle between contenteditable element, selected <tab>, urlbar, searchbar and <html>
Flags: needinfo?(arni2033)
Okay, I can reproduce now, thanks!
I looked at the patch for bug 669026 to get some idea of what might have changed to cause this, and nothing jumped out at me.  Neil, do you have any ideas?  Or do you know who might know more?  A minimal test-case is

1) data:text/html,<!doctype html><div contenteditable></div>

2) Hit Tab/Shift-Tab repeatedly, nothing happens

whereas without the "contenteditable", Tab cycles through the various things as expected.  Reportedly this is a regression from bug 669026.

I don't know anything about the code in question, so unfortunately I don't think I can help much unless someone can point me in the right direction.
Flags: needinfo?(neil)
You need to log in before you can comment on or make changes to this bug.