1250347 - considering removing nsToolkitProfileService check that we're running Firefox

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Bug 1024110 made toolkit/profile/nsToolkitProfileService.cpp "Check if we are running Firefox, as we don't want to create a profile on webapprt."

After bug 1238079 disables and removes the runtime, we should consider removing that check, since it seems like it won't be necessary anymore (unless there's another reason why we might not be running Firefox at that point).

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Does Thunderbird or SeaMonkey use nsToolkitProfileService.cpp?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to Panos Astithas [:past] from comment #1)
> Does Thunderbird or SeaMonkey use nsToolkitProfileService.cpp?

They probably do, but the code in question is ifdef MOZ_DEV_EDITION, which shouldn't be defined in Thunderbird nor SeaMonkey (not even on their Aurora branches).  I don't see it in the Thunderbird code in comm-central, like this configuration script:

https://dxr.mozilla.org/comm-central/source/mail/branding/aurora/configure.sh

Which seems to be the equivalent of this Firefox configuration script where MOZ_DEV_EDITION is defined:

https://dxr.mozilla.org/mozilla-central/source/browser/branding/aurora/configure.sh

I'm not sure where SeaMonkey's equivalent is.  But if SeaMonkey does define MOZ_DEV_EDITION, then presumably it would expect nsToolkitProfileService to behave the same as Firefox when that configuration flag is defined, since it's much more like Firefox than the runtime.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Cool, let's get rid of the check then.

Comment 4

[Marco Castelluccio [:marco]]

Attachment: remove_firefox_check

Comment 5

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b5c0c5a52a400998b096bf1304710d2b3a853ba
Bug 1250347 - Remove nsToolkitProfileService check that we're running Firefox. r=past

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b5c0c5a52a4