Closed Bug 1250352 Opened 4 years ago Closed 4 years ago

remove app restriction from Weave.js component

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox48 --- fixed

People

(Reporter: myk, Assigned: myk)

References

Details

Attachments

(1 file)

services/sync/SyncComponents.manifest restricts the Weave.js component to a specified list of apps, ostensibly because it isn't compatible with WebappRT, a.k.a. the desktop Web Runtime.

Once I disable and remove the desktop runtime in bug 1238079, it's theoretically possible to remove this restriction.  (In practice, it may be necessary to leave it in place, but then we should update the comment to correct the reason, as I've done for a couple of similar restrictions in the patch for bug 1238079.)
Attachment #8722242 - Flags: review?(mconnor)
Comment on attachment 8722242 [details] [diff] [review]
followup-services-sync-manifest.diff

Perhaps gps can take a look at this.
Attachment #8722242 - Flags: review?(mconnor) → review?(gps)
Comment on attachment 8722242 [details] [diff] [review]
followup-services-sync-manifest.diff

Review of attachment 8722242 [details] [diff] [review]:
-----------------------------------------------------------------

The app restrictions seem to have been added as part of you adding WebappRT. So the removal makes sense.
Attachment #8722242 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> The app restrictions seem to have been added as part of you adding WebappRT.
> So the removal makes sense.

Indeed, although other instances of the restrictions appear to have acquired additional (hidden) dependencies (though no one has updated the comments to reflect those dependencies), since tests fail when I remove them!  See bug 1250603 for more information.
https://hg.mozilla.org/mozilla-central/rev/7c31a0ae56b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1264931
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.