Closed Bug 1250396 Opened 9 years ago Closed 9 years ago

Two tiny atom-related tweaks

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(2 files)

(part 1) - Document a subtle contraint on nsIAtom
1.47 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
(part 2) - Remove nsStaticAtomStringType
1.98 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
I have tweaks.
This is something that took me a while to understand recently. Some documentation might save someone else some time in the future.
Attachment #8722361 - Flags: review?(nfroyd)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
It's only used in one file and obscures more than it enlightens.
Attachment #8722362 - Flags: review?(nfroyd)
Comment on attachment 8722361 [details] [diff] [review] (part 1) - Document a subtle contraint on nsIAtom Review of attachment 8722361 [details] [diff] [review]: ----------------------------------------------------------------- Sure. Seems like it would be a little better for it to explicitly hold the string buffer as a RefPtr, but this is fine too.
Attachment #8722361 - Flags: review?(nfroyd) → review+
Attachment #8722362 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/1e0587154744 https://hg.mozilla.org/mozilla-central/rev/2c2410d62931
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: