1250405 - [TV] Visual polish for send tab/video app icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Tori Chen [:tori]]

Make the icon inside the circle horizontally center aligned for better visual effect.

Comment 1

[Tori Chen [:tori]]

Hi Peko could you help this?

Comment 2

[Peko Chen [:pekochen]]

Attachment: Cast04_336.png

Hi, 
Please see attached file.
Thanks

Comment 3

[Josh Cheng [:josh]]

Hi Fischer,
Could you help this bug?
Thanks

Comment 4

[Fischer [:Fischer]]

Attachment: Cast04_336_app_icon_app_deck_on.png

Comment 5

[Fischer [:Fischer]]

Attachment: Old_app_icon_app_deck_on.png

Comment 6

[Fischer [:Fischer]]

@Tori,
The old app icon has considered the room for the app title, see the Old_app_icon_app_deck_on.png
The new app icon would squeezes the app tile, see the Cast04_336_app_icon_app_deck_on.png.
Do we really need this change or is other polish approach better ?
Thanks

Comment 7

[Tori Chen [:tori]]

@Fischer
Since Partner put the app title outside the logo, previous icon look unbalanced on real TV so we have decided to replace by the new horizontally aligned logo. Thanks.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1250405-update-fling-tutorial-app-icon > mozilla-b2g:master

Comment 9

[Fischer [:Fischer]]

Comment on attachment 8722924 [details] [review]
[gaia] Fischer-L:bug_1250405-update-fling-tutorial-app-icon > mozilla-b2g:master

@Rex,
This patch updates the app icon, thanks

Comment 10

[Fischer [:Fischer]]

Land to Master: https://github.com/mozilla-b2g/gaia/commit/828e3315b46a9918d90ab3432023af55c157ae42

Comment 11

[Fischer [:Fischer]]

Comment on attachment 8722924 [details] [review]
[gaia] Fischer-L:bug_1250405-update-fling-tutorial-app-icon > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1250405
[User impact] if declined: Visually unbalanced app logo
[Testing completed]: YEs
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 12

[Josh Cheng [:josh]]

Comment on attachment 8722924 [details] [review]
[gaia] Fischer-L:bug_1250405-update-fling-tutorial-app-icon > mozilla-b2g:master

Approve for TV 2.5

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:moz-v2.5 > mozilla-b2g:v2.5

Comment 14

[Fischer [:Fischer]]

Uplift to v2.5: https://github.com/mozilla-b2g/gaia/commit/a7b01cf4e9667329f4813f91310c2215cecec3ac

Comment 15

[Rid Pan]

Verify this issue on the latest build.
The icon of "Send to TV" is at the center of circle that matches "Cast04_336_app_icon_app_deck_on.png".

[Build Info]
Environment: Simulator 2.6
gaia:
https://github.com/mozilla-b2g/gaia/commit/bae79910eb2f3b1a657a40fcd5def0a898214d17
gecko:
https://hg.mozilla.org/mozilla-central/rev/bdde3fedb45be528f985a0aff373b37b010fb927

Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/cb7912a3e53b467e2941c1baaa1c6517ffd271fe
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0e6591c6e9e23b94ffa0a692139eca2095dba4ac
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

Comment 16

[Rid Pan]

Sorry for the typo.
The correct v2.5 is below:

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/71952d4b5417796380ddab274c5566a8eced2f8b
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0b279b0579ae5656e3df34d522af06800e0a03bf
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3