1250430 - Remove support of "srcdir" loader

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

Now that we have the reload addon, there isn't much value in keeping the srcdir loader which offer a subset of what the addon already do.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b78a47bbfff8

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8722446 [details] [diff] [review]
patch v1

Review of attachment 8722446 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webide/content/webide.js
@@ -1156,5 @@
>      UI.contentViewer.fullZoom = 1;
>      Services.prefs.setCharPref("devtools.webide.zoom", 1);
>    },
>  
>    reloadDevtools: function(event) {

Do we need this empty function...?  Does something else call it?

Comment 4

[Alexandre Poirot [:ochameau]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Comment on attachment 8722446 [details] [diff] [review]
> patch v1
> 
> Review of attachment 8722446 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: devtools/client/webide/content/webide.js
> @@ -1156,5 @@
> >      UI.contentViewer.fullZoom = 1;
> >      Services.prefs.setCharPref("devtools.webide.zoom", 1);
> >    },
> >  
> >    reloadDevtools: function(event) {
> 
> Do we need this empty function...?  Does something else call it?

The xul:command from webide.xul, but I removed it. That's just a leftover.

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df934e0cea8f

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Removed the leftover.

Comment 7

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/49253a251d3e6b783e7d985a81b669e2eeb31c97
Bug 1250430 - Remove SrcDir loader support from devtools. r=jryans

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49253a251d3e