1250434 - "Performance" and "Shader Editor" are cut off in toolbar

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Elbart]

Attachment: devtools_cut_off.png

The captions of the buttons are cut off, regardless of how many buttons are enabled.

Comment 1

[Brian Grinstead [:bgrins]]

We shrunk the max-width on the tabs in Bug 1245947, so that's most likely causing this

Comment 2

[Brian Grinstead [:bgrins]]

Elbart, what OS / version are you using?

Comment 3

[Elbart]

Win 7, Nightly 20160223

Comment 4

[Elbart]

.devtools-tab {
  max-width: 100px;
}

No cut-off with max-width changed to 100px from 95px.

Comment 5

[Brian Grinstead [:bgrins]]

Can confirm on perf tool here (but not style editor for some reason): http://mozilla-releng-blobs.s3.amazonaws.com/blobs/mozilla-central/sha512/85122af4d36b42977e58be5f0565dbc2eb1a72b34495db20975da20a9726db05f849b58302ad6abcd335cbd86a26eefea24fd917ea23bc895fab41eeba58b423

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1250434 - Bump up devtools tab width a bit to fix text overflow on Win7;r=gl

Review commit: https://reviewboard.mozilla.org/r/36187/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36187/

Comment 7

[Brian Grinstead [:bgrins]]

Mozscreenshots try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6992a6f801c1

Comment 8

[Elbart]

(In reply to (Unavailable until 3-7) Brian Grinstead [:bgrins] from comment #5)
> Can confirm on perf tool here (but not style editor for some reason):
Sorry, it's "Shader Editor".

Comment 9

[Brian Grinstead [:bgrins]]

Looks like this fixes the text overflow as expected, at least for English locale and default os theme: http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/498433f97dab8b4965a7862a9d6f1dba0c59ed20f70158c9293dc529122a5f02fa544a03444e1f5ce76bbcd11288f8cdfbee29d5506b8f47f7b6ad9bba4f7508

All screenshots can be seen in the 'ss' job here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6992a6f801c1&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false&selectedJob=17129481

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8722715 [details]
MozReview Request: Bug 1250434 - Bump up devtools tab width a bit to fix text overflow on Win7;r=gl

https://reviewboard.mozilla.org/r/36187/#review32893

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e73efeaf2ec8

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e73efeaf2ec8

Comment 13

[Saheda Reza [:Antora]]

Reproduced this bug according to 47.0a1 (2016-2-23) 

Verified is done by Latest Nightly
Build ID 	20160302030209
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:47.0) Gecko/20100101 Firefox/47.0
 
Tested OS-Windows8.1 32bit

Comment 14

[Meraj Kazi]

Successfully reproduced this bug in 47.0a1 (2016-2-23) on Linux 3.13.0-37-generic x86-64 

Found this bug in Latest Beta 47.0b2

Build ID 	20160502152141 
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0 

[bugday-20160504]

Comment 15

[Mohammad Maruf Islam]

As this bug is verified on both windows (comment 13) and Linux (Comment 14), I am marking this as verified!