Remove code that depends on the dom.mozApps.auto_confirm_install pref in AppsUtils.jsm

RESOLVED FIXED in Firefox 48

Status

Core Graveyard
DOM: Apps
RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
mozilla48

Firefox Tracking Flags

(firefox47 affected, firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
After bug 1238079, this code will be unnecessary:

    // Before bug 910473, this is a temporary workaround to get correct path
    // from child process in mochitest.
    let prefName = "dom.mozApps.auto_confirm_install";
    if (Services.prefs.prefHasUserValue(prefName) &&
        Services.prefs.getBoolPref(prefName)) {
      return { "path": app.basePath + "/" + app.id,
               "isCoreApp": isCoreApp };
    }
(Assignee)

Comment 1

2 years ago
I'll try to do this once bug 1238079 lands.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8728438 [details] [diff] [review]
remove_appsutils_workaround
Attachment #8728438 - Flags: review?(myk)
Attachment #8728438 - Flags: review?(myk) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/01dd32892033
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

6 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.