[e10s] browser.xml and remote-browser.xml shouldn't individually add observers for browser:purge-session-history

NEW
Unassigned

Status

()

Firefox
Tabbed Browser
P3
normal
2 years ago
2 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

(Blocks: 1 bug, {perf})

44 Branch
Points:
---

Firefox Tracking Flags

(e10s+)

Details

(Reporter)

Description

2 years ago
Because all they're doing is then converting it into a message that triggers purging the session history in browser-content.js

Instead, there should just be one observer (nsBrowserGlue.js seems to already do this and would probably do nicely) that broadcasts the async message once to every process, so it gets picked up in every browser-content.js. Then we also don't need to worry about removing the observer in the destroy() method, which doesn't always get called (see bug 1249439).

It also looks like the starting time gets lost and we just purge all the history out of the browsers. Not sure if that can easily be fixed when fixing this, but it would be a nice bonus.

Updated

2 years ago
tracking-e10s: --- → +
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.