1250488 - Modify FTU experience on Hello add-on v1.0

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

Since FF45 will ship with v1.0 of the add-on we need to adjust the FTU to inform users as well as possible what Hello is about now (sharing websites).

In order to do that, this bug (that is intended to be uplifted to Beta 45 prior to 45 getting on release) requires:
- Resetting the V1.0 preference to ensure everyone sees the FTU panel (previous or existing users)
- Fix panel height bug (currently the v1.0 FTU panel is too high)
- Change the content of the first door hanger to fit the new user journey description (content to be confirmed)
- Change the content of the web page that shows the FTU (https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/hello/start/) to match the new FTU implemented on v1.1 with the slidesshow

Comment 1

[Mark Banner (:standard8)]

Note: we just need a beta specific patch for this.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Fix Hello UITour window size + show <=45 users FTU again

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0843eeb0011e

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: panel before height change

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: panel after height change

I've attached two screenshots showing the panel fix.  The preference change will cause people to be shown the tour again.  Updated content for that comes from the web and will land separately.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8722663 [details] [diff] [review]
Fix Hello UITour window size + show <=45 users FTU again

Looks good. r=Standard8

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8722663 [details] [diff] [review]
Fix Hello UITour window size + show <=45 users FTU again

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Users won't get a tour of the changes that have happened since 45.
[Describe test coverage new/current, TreeHerder]: This is an older version of the FTU tour that we previously used and had turned off, the code has unit tests. I've also manually tested the try push on all three platforms.
[Risks and why]: Low, simple change to re-enable previous code and correct the height of the panel
[String/UUID change made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8722663 [details] [diff] [review]
Fix Hello UITour window size + show <=45 users FTU again

We need that for 45, taking it.
should be in 45 beta 10

Comment 9

[Mark Banner (:standard8)]

Landed direct on beta, as its only landing there:

https://hg.mozilla.org/releases/mozilla-beta/rev/7f1106d85767

Comment 10

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Verified using Firefox 45 beta 10 across platforms (Windows 7 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit) that the FTU is properly displayed and hitting 'Getting started' will open a new tab where the tour page will load. 

A note here is that we still encountered bug 1110700, and the same behaviour with high contrast theme or when installing a normal theme (in case of the themes, after a restart the panel will show content)