Closed Bug 1250506 Opened 4 years ago Closed 4 years ago

check if node is acceptable as a child before creating an accessible for it

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8722506 - Flags: review?(dbolter)
Comment on attachment 8722506 [details] [diff] [review]
patch

Review of attachment 8722506 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsCoreUtils.cpp
@@ +687,5 @@
>    obsService->NotifyObservers(event, NS_ACCESSIBLE_EVENT_TOPIC, nullptr);
>  }
> +
> +void
> +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)

nit: I'd prefer aContent over aEl.

::: accessible/xul/XULFormControlAccessible.cpp
@@ +173,5 @@
>  
>    // XXX: no children until the button is menu button. Probably it's not
>    // totally correct but in general AT wants to have leaf buttons.
> +
> +  nsAutoString role;

nit: extraneous line space
Attachment #8722506 - Flags: review?(dbolter) → review+
(In reply to David Bolter [:davidb] from comment #1)

> > +void
> > +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)
> 
> nit: I'd prefer aContent over aEl.

I would keep aEl because this is a DOM element (bindings are not applied to text nodes), it would make more sense to fix type here rather sync names.
(In reply to alexander :surkov from comment #2)
> (In reply to David Bolter [:davidb] from comment #1)
> 
> > > +void
> > > +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)
> > 
> > nit: I'd prefer aContent over aEl.
> 
> I would keep aEl because this is a DOM element (bindings are not applied to
> text nodes), it would make more sense to fix type here rather sync names.

I see, thanks. I'll leave that up to you.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8842a853d8f3f8c8756544a233d3583243142688
Bug 1250506 - check if node is acceptable as a child before creating an accessible for it, r=davidb
https://hg.mozilla.org/mozilla-central/rev/8842a853d8f3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.