1250506 - check if node is acceptable as a child before creating an accessible for it

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8722506 [details] [diff] [review]
patch

Review of attachment 8722506 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsCoreUtils.cpp
@@ +687,5 @@
>    obsService->NotifyObservers(event, NS_ACCESSIBLE_EVENT_TOPIC, nullptr);
>  }
> +
> +void
> +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)

nit: I'd prefer aContent over aEl.

::: accessible/xul/XULFormControlAccessible.cpp
@@ +173,5 @@
>  
>    // XXX: no children until the button is menu button. Probably it's not
>    // totally correct but in general AT wants to have leaf buttons.
> +
> +  nsAutoString role;

nit: extraneous line space

Comment 2

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #1)

> > +void
> > +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)
> 
> nit: I'd prefer aContent over aEl.

I would keep aEl because this is a DOM element (bindings are not applied to text nodes), it would make more sense to fix type here rather sync names.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to alexander :surkov from comment #2)
> (In reply to David Bolter [:davidb] from comment #1)
> 
> > > +void
> > > +nsCoreUtils::XBLBindingRole(const nsIContent* aEl, nsAString& aRole)
> > 
> > nit: I'd prefer aContent over aEl.
> 
> I would keep aEl because this is a DOM element (bindings are not applied to
> text nodes), it would make more sense to fix type here rather sync names.

I see, thanks. I'll leave that up to you.

Comment 4

[alexander :surkov (:asurkov)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88b3f983796d

Comment 5

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8842a853d8f3f8c8756544a233d3583243142688
Bug 1250506 - check if node is acceptable as a child before creating an accessible for it, r=davidb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8842a853d8f3