1250509 - make pretty print nicer for accessible trees in testing

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8722509 [details] [diff] [review]
patch

Review of attachment 8722509 [details] [diff] [review]:
-----------------------------------------------------------------

good with just a couple of nits.

::: accessible/tests/mochitest/common.js
@@ +762,5 @@
>      return "[ " + getNodePrettyName(aIdentifier) + " ]";
>  
>    if (aIdentifier && typeof aIdentifier === "object" ) {
> +    var treeObj = normalizeAccTreeObj(aIdentifier);
> +    if ("role" in treeObj) {

nit: if (treeObj.role) {..}

@@ +765,5 @@
> +    var treeObj = normalizeAccTreeObj(aIdentifier);
> +    if ("role" in treeObj) {
> +      function stringifyTree(aObj) {
> +        var text = roleToString(aObj.role) + ": [ ";
> +        if ("children" in aObj) {

nit: if (aObj.children)

@@ +776,5 @@
> +          }
> +        }
> +        return text + "] ";
> +      }
> +      return "{ " + stringifyTree(treeObj) + " }";

nit: `{ ${stringifyTree(treeObj)} }`

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Yura Zenevich [:yzen] from comment #1)

> ::: accessible/tests/mochitest/common.js
> @@ +762,5 @@
> >      return "[ " + getNodePrettyName(aIdentifier) + " ]";
> >  
> >    if (aIdentifier && typeof aIdentifier === "object" ) {
> > +    var treeObj = normalizeAccTreeObj(aIdentifier);
> > +    if ("role" in treeObj) {
> 
> nit: if (treeObj.role) {..}

isn't if (prop in obj) a correct way to check if property is presented in the object? I realize that role is never 0, so they are identical but anyway

> nit: `{ ${stringifyTree(treeObj)} }`

k

Comment 3

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/405edcc5dbfaffd76929d92ab50339ed947bd8f9
Bug 1250509 - make pretty print nicer for accessible trees in testing, r=yzen

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/405edcc5dbfa