1250527 - [Sync Tabs Sidebar] Sidebar and panel "sync now" buttons should use the same terminology

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2, minor)

Description

[Adrian Florinescu [:adrian_sv]]

[Sync Tabs] has "Sync Now" as a sync option and the same option in [Sync Tabs Sidebar] is called Refresh. The UI should be kept similar as much as possible for usability sake since it's basically the same feature from sync point of view.

Another note here against using "Refresh" as a label for sync in this case is that when you sync the Sync Tabs Sidebar you do it vs the cloud and not actually versus another device/machine. The user might be mislead to think that pressing Refresh will bring the new tabs he changed on the target machine without syncing before the target.

Therefore, for the above reasons I would suggest at least renaming the "Refresh" option from Sync Sidebar to "Sync Now".

Comment 1

[Mark Hammond [:markh]]

Ryan, thoughts on this?

Comment 2

[Ryan Feeley [:rfeeley]]

On Mac, I see "Refresh List" and I agree that "Sync Now" is better. Good catch Adrian!

Comment 3

[Chris Karlof [:ckarlof]]

Ryan, should this block the sidebar riding the trains? It's possible we can uplift since it doesn't introduce a new string change.

Comment 4

[Ryan Feeley [:rfeeley]]

This is definitely NOT a blocker.

Comment 5

[Lina Cambridge (she/her) [:lina]]

Attachment: MozReview Request: Bug 1250527 - Use the "Sync Now" string in the Synced Tabs sidebar. r=markh

Review commit: https://reviewboard.mozilla.org/r/38001/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38001/

Comment 6

[Mark Hammond [:markh]]

Comment on attachment 8726450 [details]
MozReview Request: Bug 1250527 - Use the "Sync Now" string in the Synced Tabs sidebar. r=markh

https://reviewboard.mozilla.org/r/38001/#review34567

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6b7cac27bb83

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b7cac27bb83

Comment 9

[Adrian Florinescu [:adrian_sv]]

verified fixed on:
Version 47.0a1 Build ID 20160307030208 / Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0

Also verified on windows10 and MacOsX.