Closed
Bug 1250574
Opened 9 years ago
Closed 9 years ago
The fade-in transition on each test result brings firefox to its knees
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nical, Assigned: wlach)
Details
Attachments
(1 file)
That fade-in transition (with hundreds of elements transitioning at once when the page loads) causes us go down a bad layer heuristic in gecko and things get very slow (crashy even, with bug 1245241, which will be fixed soon).
I don't think the effect itself is super important, so I suggest we remove it, at least until we figure out good heuristics in gecko for websites that that create more than a thousand individual transitions in a single transaction.
Assignee | ||
Comment 1•9 years ago
|
||
Yeah, I think this is more a side effect of how I implemented the transitions than what was intended (I really only wanted a transition when people opened up a job group). I'll take this.
Assignee: nobody → wlachance
Updated•9 years ago
|
Priority: -- → P2
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8723818 [details] [review]
[treeherder] wlach:1250574 > mozilla:master
Not entirely crazy about using jQuery animations, but I don't really have time to figure out how to do this with CSS, if it's even possible. This should avoid a whole lot of gotchas, though it will make treeherder a bit less of a stress test on the platform. :)
Attachment #8723818 -
Flags: review?(cdawson)
Comment 4•9 years ago
|
||
Comment on attachment 8723818 [details] [review]
[treeherder] wlach:1250574 > mozilla:master
The approach looks great! So r+ when you switch fading out to fading in for jobs to groups. :)
Attachment #8723818 -
Flags: review?(cdawson) → review+
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/2b3ab1ff197546678c218b0ea96629071055943c
Bug 1250574 - Animate job group expansion/deletion only on click
We were animating all transitions for the job elements before, which
could be extremely expensive.
Assignee | ||
Comment 6•9 years ago
|
||
Pushed with the suggested changes! I realized I could actually make the code simpler by making it behave how you specified, so double win. :)
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•