1250582 - Record TLS 1.3 fallbacks in SSL_FALLBACK_LIMIT_REACHED (or equivalent)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Martin Thomson [:mt:]]

SSL_FALLBACK_LIMIT_REACHED has a bad design: it can't be extended.  It's also too general for its own good.  Given the current values, it's probably best to simply retire it and make a design that can be extended.

We really only want to know what version of TLS we fell back to.  The other information in this histogram only lets us query user preferences.

We should replace SSL_FALLBACK_LIMIT_REACHED with another histogram.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1250582 - Remove SSL_FALLBACK_LIMIT_REACHED telemetry.

Bug 1084025 added this telemetry to measure the impact of bumping the fallback limit.
But we already bumped the fallback limit to TLS 1.2 long before. We will not need this kind of telemetry until we bump the fallback limit to TLS 1.3 that will not happen in the near future. So let's just remove wasting resource for now.

Review commit: https://reviewboard.mozilla.org/r/64746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64746/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8771648 [details]
Bug 1250582 - Remove SSL_FALLBACK_LIMIT_REACHED telemetry.

https://reviewboard.mozilla.org/r/64746/#review62094

Great - r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e994cb3fb30
Remove SSL_FALLBACK_LIMIT_REACHED telemetry. r=keeler

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e994cb3fb30