Record TLS 1.3 fallbacks in SSL_FALLBACK_LIMIT_REACHED (or equivalent)

RESOLVED FIXED in Firefox 50

Status

()

P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mt, Assigned: emk)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
SSL_FALLBACK_LIMIT_REACHED has a bad design: it can't be extended.  It's also too general for its own good.  Given the current values, it's probably best to simply retire it and make a design that can be extended.

We really only want to know what version of TLS we fell back to.  The other information in this histogram only lets us query user preferences.

We should replace SSL_FALLBACK_LIMIT_REACHED with another histogram.
Whiteboard: [psm-backlog]
(Assignee)

Comment 1

2 years ago
Created attachment 8771648 [details]
Bug 1250582 - Remove SSL_FALLBACK_LIMIT_REACHED telemetry.

Bug 1084025 added this telemetry to measure the impact of bumping the fallback limit.
But we already bumped the fallback limit to TLS 1.2 long before. We will not need this kind of telemetry until we bump the fallback limit to TLS 1.3 that will not happen in the near future. So let's just remove wasting resource for now.

Review commit: https://reviewboard.mozilla.org/r/64746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64746/
Attachment #8771648 - Flags: review?(dkeeler)
(Assignee)

Updated

2 years ago
Blocks: 1286694
Comment on attachment 8771648 [details]
Bug 1250582 - Remove SSL_FALLBACK_LIMIT_REACHED telemetry.

https://reviewboard.mozilla.org/r/64746/#review62094

Great - r=me
Attachment #8771648 - Flags: review?(dkeeler) → review+
Assignee: nobody → VYV03354
Priority: -- → P1
Whiteboard: [psm-backlog] → [psm-assigned]

Comment 3

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/8e994cb3fb30
Remove SSL_FALLBACK_LIMIT_REACHED telemetry. r=keeler

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e994cb3fb30
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.