Closed
Bug 12506
Opened 25 years ago
Closed 25 years ago
[MLK] Huge memory leakage on pages with animated GIFs
Categories
(Core :: Networking, defect, P2)
Tracking
()
VERIFIED
FIXED
M10
People
(Reporter: sfraser_bugs, Assigned: rpotts)
References
Details
Current builds are leaking large amounts of memory; sitting on www.abcnews.com for 2 minutes will leak around 80Mb. This leakage seems to be worse on pages with animated GIFs.
Comment 1•25 years ago
|
||
I believe this is a duplicate of 6409, but am leaving open so that sfraser or pnunn can decide for themselves.
Reporter | ||
Comment 2•25 years ago
|
||
I believe this leak is more serious than 6409, and has got worse in the last few days.
Reporter | ||
Updated•25 years ago
|
Assignee: pnunn → warren
Component: ImageLib → Necko
Reporter | ||
Comment 3•25 years ago
|
||
Change component to necko, reassign to warren.
Reporter | ||
Updated•25 years ago
|
Priority: P3 → P2
Hardware: Macintosh → All
Reporter | ||
Comment 4•25 years ago
|
||
This leakage appears to be coming from nsBuffer::PushWriteSegment(), which is called from nsSocketTransport code. We are allocating chunks about 500K in size, which for some reason never get deleted.
Reporter | ||
Comment 5•25 years ago
|
||
#define MAX_IO_BUFFER_SIZE (1024*1024)//8192 that's a whole megabyte. Is that right?
Reporter | ||
Comment 6•25 years ago
|
||
We appear to be leaking nsHTTPChannels, which in turn leaks nsHTTPRequests, and their associated buffers.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 7•25 years ago
|
||
I'm working on this now.
Comment 8•25 years ago
|
||
http://www.cybersight.com/~bruce/apprunner.mongo.19990827.log might contain some useful purify data.
Updated•25 years ago
|
Target Milestone: M10
Reporter | ||
Comment 9•25 years ago
|
||
There are rumors that gagan fixed at least part of this, so I'm cc:ing him.
Comment 10•25 years ago
|
||
I just checked in a change to reduce the buffer size. Now the socket transport should allocate up to 64k in 4k chunks before deciding to suspend the request. I don't know if those are the right numbers, but they're better than the 1Mb that we had before. But that just makes the leak smaller. I haven't looked into why we're leaking here.
Updated•25 years ago
|
Severity: normal → critical
Comment 11•25 years ago
|
||
I was told that the ownership issues in here were going to be fixed by rpotts once he returned from vacation? Is this true? Right now, this is dragging down a lot of data and obscuring real results in Purify. What's the status?
Updated•25 years ago
|
Assignee: warren → rpotts
Status: ASSIGNED → NEW
Comment 12•25 years ago
|
||
I'm guessing the following two lines of the log are the culprit: NS_OpenURI(nsIChannel**,nsIURI*) [nsNeckoUtil.cpp:62] nsDocumentBindInfo::Bind(nsIURI*,nsIStreamListener*,nsIInputStream*) [nsDocLoader.cpp:1675] I suspect that the document bind info is caching the channel, but it's destructor isn't releasing it. Assigning to Rick.
Comment 13•25 years ago
|
||
vidur indicates on #mozilla that there is a circular dependency between the docloader and the loadgroup, and that forces the webshell to leak.
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 14•25 years ago
|
||
We are no longer leaking channels. This should have been fixed when the M9 branch landed. I went to www.abcnews.com and stayed there for a while and didn't see any large memory leakage... The fact that WebShells are not being deleted is *not* related to this bug since the webshell is not destroyed when new pages are loaded... I believe that vidur is looking into the webshell leaks. Let me know if you are still seeing channel leakage. -- rick
Comment 15•25 years ago
|
||
Okay, then I will dig up specific Necko leaks and begin filing bugs on each of them.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 16•25 years ago
|
||
Apprunner running approximately 2 minutes on Win NT leaked about 100K. 100K != 80 MB, so marking as verified.
Comment 17•25 years ago
|
||
Bulk move of all Necko (to be deleted component) bugs to new Networking component.
Comment 18•18 years ago
|
||
The problem is still in the very last firefox release (but not in mozilla suite) try http://facs.scripps.edu/surf/images/euranim.gif REOPEN
You need to log in
before you can comment on or make changes to this bug.
Description
•