Remove the reverse proxy from l20n.js to l10n.js

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We currently have proxies from l20n to l10n API and reverse.

I'd like to remove the reverse one to clean up l20n.js file.

If I understand correctly, all our code in Gaia either uses L20n or uses l10n.js and can use l10n->l20n proxy then.

There may be a few files in shared that will have to be migrated to l20n API first.
Assignee

Updated

3 years ago
See Also: → 1204660
Assignee

Updated

3 years ago
Assignee: nobody → gandalf
Comment on attachment 8722632 [details] [review]
[gaia] zbraniecki:1250628-remove-l20n-reverse-proxy > mozilla-b2g:master

I'm afraid I will not get reviewers for particular apps anymore, so Stas, can you review this patch for me?

I looked at shared code and moved all files that are used in both, l20n and l10n apps to use l20n API (since l10n->l20n proxy stays).

I tested it on the device and it seems to work well, also no new test failures.
Attachment #8722632 - Flags: review?(stas)
Comment on attachment 8722632 [details] [review]
[gaia] zbraniecki:1250628-remove-l20n-reverse-proxy > mozilla-b2g:master

LGTM, thanks.  This patch makes me very happy.
Attachment #8722632 - Flags: review?(stas) → review+
Commit: https://github.com/mozilla-b2g/gaia/commit/a3f30950910c634771f2e74e1890b0e005e30482
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.