1250628 - Remove the reverse proxy from l20n.js to l10n.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We currently have proxies from l20n to l10n API and reverse.

I'd like to remove the reverse one to clean up l20n.js file.

If I understand correctly, all our code in Gaia either uses L20n or uses l10n.js and can use l10n->l20n proxy then.

There may be a few files in shared that will have to be migrated to l20n API first.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1250628-remove-l20n-reverse-proxy > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8722632 [details] [review]
[gaia] zbraniecki:1250628-remove-l20n-reverse-proxy > mozilla-b2g:master

I'm afraid I will not get reviewers for particular apps anymore, so Stas, can you review this patch for me?

I looked at shared code and moved all files that are used in both, l20n and l10n apps to use l20n API (since l10n->l20n proxy stays).

I tested it on the device and it seems to work well, also no new test failures.

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 8722632 [details] [review]
[gaia] zbraniecki:1250628-remove-l20n-reverse-proxy > mozilla-b2g:master

LGTM, thanks.  This patch makes me very happy.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/a3f30950910c634771f2e74e1890b0e005e30482

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

L20n.js: https://github.com/l20n/l20n.js/commit/ab671091b0f2495ca6aa48506e81da347d6ff1fb

We now use web target for gaia.