1250641 - Adding a test parameter to ./mach external-media-tests fails

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Syd Polk :sydpolk]

Syd-Polks-Mozilla-MBP:mozilla-central spolk$ ./mach external-media-tests --urls dom/media/test/external/external_media_tests/urls/youtube/short1-15.ini dom/media/test/external/external_media_tests/playback/youtube/manifest.ini 
usage: mach [-h] [-v] [--emulator {x86,arm}]
            [--emulator-binary EMULATOR_BINARY] [--emulator-img EMULATOR_IMG]
            [--emulator-res EMULATOR_RES] [--sdcard SDCARD] [--no-window]
            [--logcat-dir LOGDIR] [--logcat-stdout] [--address ADDRESS]
            [--device DEVICE_SERIAL] [--adb-host ADB_HOST]
            [--adb-port ADB_PORT] [--type TYPE] [--homedir HOMEDIR]
            [--app APP] [--app-arg APP_ARGS] [--binary BINARY]
            [--profile PROFILE] [--pref PREFS_ARGS]
            [--preferences PREFS_FILES] [--addon ADDON] [--repeat REPEAT]
            [--testvars TESTVARS] [--tree TREE] [--symbols-path SYMBOLS_PATH]
            [--timeout TIMEOUT] [--startup-timeout STARTUP_TIMEOUT]
            [--shuffle] [--shuffle-seed SHUFFLE_SEED]
            [--total-chunks TOTAL_CHUNKS] [--this-chunk THIS_CHUNK]
            [--sources SOURCES] [--server-root SERVER_ROOT]
            [--gecko-log GECKO_LOG] [--logger-name LOGGER_NAME] [--jsdebugger]
            [--pydebugger PYDEBUGGER] [--socket-timeout SOCKET_TIMEOUT]
            [--e10s] [--tag TEST_TAGS] [--workspace WORKSPACE] [--urls URLS]
            [--browsermob-script BROWSERMOB_SCRIPT]
            [--browsermob-port BROWSERMOB_PORT] [--log-unittest LOG_UNITTEST]
            [--log-raw LOG_RAW] [--log-html LOG_HTML] [--log-tbpl LOG_TBPL]
            [--log-xunit LOG_XUNIT] [--log-mach LOG_MACH]
            [--log-mach-buffer LOG_MACH_BUFFER]
            [--log-tbpl-buffer LOG_TBPL_BUFFER] [--log-mach-verbose]
            [--log-mach-level LOG_MACH_LEVEL] [--log-raw-level LOG_RAW_LEVEL]
            [--log-tbpl-level LOG_TBPL_LEVEL]
            [tests [tests ...]]
mach: error: unrecognized arguments: dom/media/test/external/external_media_tests/playback/youtube/manifest.ini
Syd-Polks-Mozilla-MBP:mozilla-central spolk$

Comment 1

[Syd Polk :sydpolk]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10ec6617fe03

Comment 2

[Syd Polk :sydpolk]

Attachment: MozReview Request: Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf

Review commit: https://reviewboard.mozilla.org/r/36209/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36209/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8722746 [details]
MozReview Request: Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf

https://reviewboard.mozilla.org/r/36209/#review32799

::: dom/media/test/external/mach_commands.py:35
(Diff revision 1)
>      parser = MediaTestArguments()
>      commandline.add_logging_group(parser)
> -    args = parser.parse_args()
> +    args = parser.parse_args(args=kwargs)

I /think/ you parse arguments twice - once in mach (see `setup_argument_parser()` above) and again here. I /think/ something like the following will work to create a "fake" parsed arguments object that has arguments stored as attributes:

args = object()
for k, v in kwargs.items():
    setattr(args, k, v)
    
If this doesn't work, I guess what you have is good enough provided it works.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8722746 [details]
MozReview Request: Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf

https://reviewboard.mozilla.org/r/36209/#review32813

::: dom/media/test/external/mach_commands.py:37
(Diff revision 1)
> -    args = parser.parse_args()
> +    args = parser.parse_args(args=kwargs)

Also, could you add a comment (or extra detail in commit message) about why you need to pass something to parser.parse_args() to fix the mach command?

Comment 5

[Syd Polk :sydpolk]

Comment on attachment 8722746 [details]
MozReview Request: Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36209/diff/1-2/

Comment 6

[Syd Polk :sydpolk]

https://reviewboard.mozilla.org/r/36209/#review32813

> Also, could you add a comment (or extra detail in commit message) about why you need to pass something to parser.parse_args() to fix the mach command?

I don't think we need that comment anymore. Let me know.

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8722746 [details]
MozReview Request: Bug 1250641 - Fix passing in test parameter to ./mach external-media-tests. r?gps, r?maja_zf

https://reviewboard.mozilla.org/r/36209/#review32985

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d78875efa55a

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d78875efa55a