Closed
Bug 1250658
Opened 8 years ago
Closed 8 years ago
balrog submitter: use blob suffixes
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(3 files, 1 obsolete file)
58 bytes,
text/x-review-board-request
|
jlund
:
review+
rail
:
checked-in+
|
Details |
58 bytes,
text/x-review-board-request
|
jlund
:
review+
|
Details |
3.68 KB,
patch
|
jlund
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
balrog submitter should be able submit to blobs with different suffix so we can run current release process in parallel with release promotion.
Updated•8 years ago
|
Summary: balrog submitter: use blog suffixes → balrog submitter: use blob suffixes
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36167/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36167/
Attachment #8722657 -
Flags: review?(jlund)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36171/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36171/
Attachment #8722658 -
Flags: review?(jlund)
Assignee | ||
Comment 3•8 years ago
|
||
https://github.com/mozilla/funsize/blob/master/docker/funsize-balrog-submitter/scripts/funsize-balrog-submitter.py#L114 is how we use it. Balrog client knows how to handle it (it adds "-dummy" to the blob name)
Comment 4•8 years ago
|
||
Comment on attachment 8722657 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund https://reviewboard.mozilla.org/r/36167/#review32755 ::: buildfarm/release/release-runner.py:326 (Diff revision 1) > + if extra_balrog_submitter_params: won't jinja require this to exist when it tries to evaluate it? could we pass it even when it is the None case?
Attachment #8722657 -
Flags: review?(jlund)
Comment 5•8 years ago
|
||
Comment on attachment 8722658 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund https://reviewboard.mozilla.org/r/36171/#review32757 ::: modules/releaserunner/templates/release-runner.ini.erb:40 (Diff revision 1) > +extra_balrog_submitter_params = <%= @env_config["extra_balrog_submitter_params"] %> I didn't know ini allows for `item =` without a value on the other side..
Attachment #8722658 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #5) > Comment on attachment 8722658 [details] > MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund > > https://reviewboard.mozilla.org/r/36171/#review32757 > > ::: modules/releaserunner/templates/release-runner.ini.erb:40 > (Diff revision 1) > > +extra_balrog_submitter_params = <%= @env_config["extra_balrog_submitter_params"] %> > > I didn't know ini allows for `item =` without a value on the other side.. it works actually :) https://gist.github.com/rail/49b0eab5a684cced8fee
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #4) > Comment on attachment 8722657 [details] > MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund > > https://reviewboard.mozilla.org/r/36167/#review32755 > > ::: buildfarm/release/release-runner.py:326 > (Diff revision 1) > > + if extra_balrog_submitter_params: > > won't jinja require this to exist when it tries to evaluate it? We use "if ... defined" for this variable: https://github.com/mozilla/releasetasks/blob/master/releasetasks/templates/enUS.yml.tmpl#L268 > could we pass it even when it is the None case? None is still "defined", what may mess up the cmd in https://github.com/mozilla/funsize/blob/master/docker/funsize-balrog-submitter/runme.sh#L22
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8722657 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund See my commetns
Attachment #8722657 -
Flags: review?(jlund)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8722657 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36167/diff/1-2/
Assignee | ||
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36199/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36199/
Attachment #8722731 -
Flags: review?(jlund)
Assignee | ||
Comment 11•8 years ago
|
||
https://reviewboard.mozilla.org/r/36167/#review32795
Assignee | ||
Updated•8 years ago
|
Attachment #8722657 -
Flags: review?(jlund)
Assignee | ||
Updated•8 years ago
|
Attachment #8722731 -
Flags: review?(jlund)
Assignee | ||
Comment 12•8 years ago
|
||
Attachment #8722779 -
Flags: review?(jlund)
Assignee | ||
Updated•8 years ago
|
Attachment #8722731 -
Flags: review?(jlund)
Updated•8 years ago
|
Attachment #8722657 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8722731 -
Flags: review?(jlund) → review+
Comment 13•8 years ago
|
||
Comment on attachment 8722731 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund https://reviewboard.mozilla.org/r/36199/#review32807
Updated•8 years ago
|
Attachment #8722779 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8722658 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund remote: https://hg.mozilla.org/build/puppet/rev/ab221f90daf6 remote: https://hg.mozilla.org/build/puppet/rev/d816d7fc3bec
Attachment #8722658 -
Flags: checked-in+
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8722779 [details] [diff] [review] tools.diff https://hg.mozilla.org/build/tools/rev/d3764f6a244c
Attachment #8722779 -
Flags: checked-in+
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8722731 [details] MozReview Request: Bug 1250658 - balrog submitter: use blob suffixes r?jlund landed to date: https://hg.mozilla.org/projects/date/rev/a2c9b7ae135a
Assignee | ||
Comment 17•8 years ago
|
||
funsize worked fine, still need to verify updates.py
Assignee | ||
Comment 18•8 years ago
|
||
Talked to bhearsum and we decided that using a separate balrog instance would be safer for now. In case we want to switch to release promotion we can just copy the blobs manually. remote: https://hg.mozilla.org/build/puppet/rev/448a1c65be94 remote: https://hg.mozilla.org/build/puppet/rev/d06d48ed8a3c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•