1250681 - Migrate remaining TV apps to l20n

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Some smaller TV apps still use l10n.js. It should be trivial to migrate them to l20n.js

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1250681-migrate-tv-to-l20n > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8722703 [details] [review]
[gaia] zbraniecki:1250681-migrate-tv-to-l20n > mozilla-b2g:master

Can you review that or assign reviewer please?

This is mostly automated move from l10n.js to l20n.js for all apps but Smart-System which requires a bit more work and is handled in bug 1247710.

Nothing fancy, but enables us to mark l10n.js as deprecated :)

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ping :)

Comment 4

[Evelyn Hung]

Comment on attachment 8722703 [details] [review]
[gaia] zbraniecki:1250681-migrate-tv-to-l20n > mozilla-b2g:master

Sorry, I'm late. It's a safe patch and looks good to me. but I'd like to have Rex double check since he knows more details of these apps. Thanks!

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8722703 [details] [review]
[gaia] zbraniecki:1250681-migrate-tv-to-l20n > mozilla-b2g:master

It's good to land it as is.
I found you modified bower-components/smart-modal-dialog, this is a fork from smart-modal-dialog, which is now renamed to fxos-modal-dialog. So we'll need to make a change to fxos-modald-dialog component too. May you open a bug for that?

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks!

Commit: https://github.com/mozilla-b2g/gaia/commit/a2c743f2e307b9147da300774f00aa54fbc5bf53

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Filed bug 1252791 for fxos-tv-modal-dialog