Closed Bug 1250746 Opened 4 years ago Closed 4 years ago

Add InitMouseEvent back to nsIDOMMouseEvent

Categories

(Core :: DOM: Core & HTML, defect)

Unspecified
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: abdelrahman, Assigned: abdelrahman)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

Removing InitMouseEvent method from nsIDOMMouseEvent interface in bug 1241764 caused build failure of mintrayr component [1] in Instantbird.

[1] https://dxr.mozilla.org/comm-central/source/im/components/mintrayr/trayToolkit.cpp#252
Whiteboard: btpp-active
Attached patch patchSplinter Review
This will not totally fix the build failure as mintrayr passes nsIDOMWindow for viewArg parameter instead of mozIDOMWindow, so I 'll file a new bug to fix this after approving this patch.
Attachment #8724142 - Flags: review?(khuey)
Comment on attachment 8724142 [details] [diff] [review]
patch

Review of attachment 8724142 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/events/nsIDOMMouseEvent.idl
@@ +12,5 @@
>   * For more information on this interface please see
>   * http://www.w3.org/TR/DOM-Level-2-Events/
>   */
>  
> +[builtinclass, uuid(5bdab8d8-7933-4c5c-b6d1-ab34481237f7)]

Changing IIDs is no longer needed.  See https://groups.google.com/forum/#!topic/mozilla.dev.platform/HE1_qZhPj1I
Attachment #8724142 - Flags: review?(khuey) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Changing IIDs is no longer needed.  See
> https://groups.google.com/forum/#!topic/mozilla.dev.platform/HE1_qZhPj1I

Ah, thanks.

I'm not sure if this bug is ready for being checked-in or needs to be tested (e.g. try server)
Status: NEW → ASSIGNED
Flags: needinfo?(khuey)
(In reply to Abdelrhman Ahmed [:abdelrhman] from comment #3)
> I'm not sure if this bug is ready for being checked-in or needs to be tested
> (e.g. try server)

It should be OK, it's just restoring previous code.
Flags: needinfo?(khuey)
https://hg.mozilla.org/mozilla-central/rev/df83e1d23721
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.