1250748 - Remove the 20s countdown timer on mach first run

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

The 20s countdown timer is horrible. Let's remove it and do something saner.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1250748 - Remove the 20s countdown timer from mach first run; r?chmanchester

Previously on first `mach` run on a system, we'd display a prompt with a
20s countdown timer after which the default state directory
(~/.mozbuild) was created. Users had to wait 20s or ctrl+c and
make the directory by hand. Either way, they'd have to re-invoke
mach to run whatever command they were trying to run.

This was annoying.

This commit makes the following changes:

1) The countdown timer is replaced with "press RETURN/ENTER to continue"
2) The requirement to re-invoke mach has been removed

On first run, people now see a message telling them to press
RETURN/ENTER. Then the directory is created and whatever mach command
they requested to run is run.

While I was here, I also changed the permissions on the newly created
directory to match what it was a few lines above. Without, we're relying
on umask, which may be permissive. UNIX convention is to use a more
restrictive umask insider user directories. So this feels like the right
behavior.

Review commit: https://reviewboard.mozilla.org/r/36235/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36235/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8722782 [details]
MozReview Request: Bug 1250748 - Remove the 20s countdown timer from mach first run; r?chmanchester

https://reviewboard.mozilla.org/r/36235/#review32819

Great. Never liked this thing.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd2b53862f81

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd2b53862f81