Implement InitPrintSettingsFromPrinter for OS/2

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: rods, Assigned: jblanco)

Tracking

(Blocks: 1 bug)

Trunk
x86
OS/2
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

17 years ago
If OS2 supports being able to get the current default settings for a printer,
then you may want to implement this.

Settings such as Page Orientation, Page Size, number of copies etc.

The idea is to get them from the printer and set them into the PrintSettings
(Reporter)

Updated

17 years ago
Depends on: 123554

Updated

17 years ago
OS: Windows 2000 → OS/2
Hardware: Other → PC
Summary: Implement InitPrintSettingsFromPrinter for OS2 → Implement InitPrintSettingsFromPrinter for OS/2

Updated

17 years ago
Blocks: 125824
(Assignee)

Comment 1

17 years ago
Created attachment 77314 [details] [diff] [review]
nsDeviceContextSpecOS2.cpp/h - now implements initprintsettings

similar to windows - added code to InitPrintSettingsFromPrinter and added
functions to query and set job properties from selected printer.
(Assignee)

Comment 2

17 years ago
Created attachment 77318 [details] [diff] [review]
printdialog.js - set copies to default copies for selected printer

should this initial copies value be set to the default printer setting for
copies?  Also, in printdialog.xul -
<menulist id="printerList" flex="1"
oncommand="setPrinterDefaultsForSelectedPrinter();">
Should this function be called everytime a printer is selected from the
dropdown list? There are no changes being made to the dialog, just extra
functions keep getting called. Maybe it should only be called once within
printdialog.js.
(Assignee)

Comment 3

17 years ago
This still needs a little work for printing to work nicely.
(Assignee)

Comment 4

17 years ago
Created attachment 77508 [details] [diff] [review]
modified nsDeviceContextSpecOS2.cpp/h to fix printing

Replacing previous nsDeviceContextSpecOS2.cpp/h patch for one where printing
works.
(Assignee)

Updated

17 years ago
Attachment #77314 - Attachment is obsolete: true
Comment on attachment 77508 [details] [diff] [review]
modified nsDeviceContextSpecOS2.cpp/h to fix printing

r=mkaply
sr=blizzard (platform specific code)
Attachment #77508 - Flags: superreview+
Attachment #77508 - Flags: review+

Comment 6

17 years ago
Comment on attachment 77508 [details] [diff] [review]
modified nsDeviceContextSpecOS2.cpp/h to fix printing

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77508 - Flags: approval+
Fix checked in.

Leaving open to talk to rod about the printdialog.js change
(Assignee)

Comment 8

17 years ago
Created attachment 77853 [details] [diff] [review]
modified printdialog.xul

removed call to setPrinterDefaultsForSelectedPrinter so it will not be called
everytime a printer is selected from the dropdown list. It is called in
printdialog.js to set up the dialog.
(Reporter)

Comment 9

17 years ago
Comment on attachment 77318 [details] [diff] [review]
printdialog.js - set copies to default copies for selected printer

look ok r=rods
Attachment #77318 - Flags: review+

Comment 10

17 years ago
Jessica Blanco wrote:
> Created an attachment (id=77853)
> modified printdialog.xul
> removed call to setPrinterDefaultsForSelectedPrinter so it will not be called
> everytime a printer is selected from the dropdown list. It is called in
> printdialog.js to set up the dialog.

Uhm, AFAIK we must call |setPrinterDefaultsForSelectedPrinter| for each new
selected printer to pick-up the default settings for it.
Think about the case when each printer has it's own defaults... we call
|setPrinterDefaultsForSelectedPrinter| once when we load the dialog - but must
be sure to pick the defaults of the new selected printer when the user changes
the printer selection...

Comment 11

17 years ago
Comment on attachment 77853 [details] [diff] [review]
modified printdialog.xul

I suggest to mark this as "obsolete" ...
Attachment #77853 - Flags: needs-work+
(Assignee)

Comment 12

17 years ago
Created attachment 80857 [details] [diff] [review]
nsDeviceContextSpecOS2.cpp modified to fix hangs/crashes when printing

Certain drivers were hanging/crashing when trying to print so I fixed my
changes in nsDeviceContextSpecOS2.cpp.
Comment on attachment 80857 [details] [diff] [review]
nsDeviceContextSpecOS2.cpp modified to fix hangs/crashes when printing

r=mkaply
sr=blizzard (platform specific code)
Attachment #80857 - Flags: superreview+
Attachment #80857 - Flags: review+
Comment on attachment 80857 [details] [diff] [review]
nsDeviceContextSpecOS2.cpp modified to fix hangs/crashes when printing

a=roc+moz for branch
Attachment #80857 - Flags: approval+
http://bugzilla.mozilla.org/attachment.cgi?id=80857&action=view

checled into branch and trunk

sent note to hewitt about sr on printdialog.js change and then I will close this 
out.

Comment 16

17 years ago
adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.
Keywords: fixed1.0.0

Comment 17

17 years ago
Can someone please verify this bug on the branch and add "verified1.0.0"
to the keywords.

also if this bug is fixed on the trunk, then how come its not marked
verified fixed?
we're waiting to see what to do with the printdialog.js change

Jessica,

Let's open a separate bug with just the printdialog.js change. You can transfer 
rods review.

I want to get this one closed.
(Assignee)

Comment 19

17 years ago
InitPrintSettingsFromPrinter for OS/2 has been fixed. Opened bug 142619 and put 
the printdialog.js patch there.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 20

17 years ago
verified fix
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.