Closed Bug 125076 Opened 23 years ago Closed 23 years ago

Implement InitPrintSettingsFromPrinter for OS/2

Categories

(Core :: Printing: Output, defect)

x86
OS/2
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: rods, Assigned: jblanco)

References

Details

Attachments

(4 files, 1 obsolete file)

If OS2 supports being able to get the current default settings for a printer, then you may want to implement this. Settings such as Page Orientation, Page Size, number of copies etc. The idea is to get them from the printer and set them into the PrintSettings
Depends on: 123554
OS: Windows 2000 → OS/2
Hardware: Other → PC
Summary: Implement InitPrintSettingsFromPrinter for OS2 → Implement InitPrintSettingsFromPrinter for OS/2
Blocks: 125824
similar to windows - added code to InitPrintSettingsFromPrinter and added functions to query and set job properties from selected printer.
should this initial copies value be set to the default printer setting for copies? Also, in printdialog.xul - <menulist id="printerList" flex="1" oncommand="setPrinterDefaultsForSelectedPrinter();"> Should this function be called everytime a printer is selected from the dropdown list? There are no changes being made to the dialog, just extra functions keep getting called. Maybe it should only be called once within printdialog.js.
This still needs a little work for printing to work nicely.
Replacing previous nsDeviceContextSpecOS2.cpp/h patch for one where printing works.
Attachment #77314 - Attachment is obsolete: true
Comment on attachment 77508 [details] [diff] [review] modified nsDeviceContextSpecOS2.cpp/h to fix printing r=mkaply sr=blizzard (platform specific code)
Attachment #77508 - Flags: superreview+
Attachment #77508 - Flags: review+
Comment on attachment 77508 [details] [diff] [review] modified nsDeviceContextSpecOS2.cpp/h to fix printing a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77508 - Flags: approval+
Fix checked in. Leaving open to talk to rod about the printdialog.js change
removed call to setPrinterDefaultsForSelectedPrinter so it will not be called everytime a printer is selected from the dropdown list. It is called in printdialog.js to set up the dialog.
Comment on attachment 77318 [details] [diff] [review] printdialog.js - set copies to default copies for selected printer look ok r=rods
Attachment #77318 - Flags: review+
Jessica Blanco wrote: > Created an attachment (id=77853) > modified printdialog.xul > removed call to setPrinterDefaultsForSelectedPrinter so it will not be called > everytime a printer is selected from the dropdown list. It is called in > printdialog.js to set up the dialog. Uhm, AFAIK we must call |setPrinterDefaultsForSelectedPrinter| for each new selected printer to pick-up the default settings for it. Think about the case when each printer has it's own defaults... we call |setPrinterDefaultsForSelectedPrinter| once when we load the dialog - but must be sure to pick the defaults of the new selected printer when the user changes the printer selection...
Comment on attachment 77853 [details] [diff] [review] modified printdialog.xul I suggest to mark this as "obsolete" ...
Attachment #77853 - Flags: needs-work+
Certain drivers were hanging/crashing when trying to print so I fixed my changes in nsDeviceContextSpecOS2.cpp.
Comment on attachment 80857 [details] [diff] [review] nsDeviceContextSpecOS2.cpp modified to fix hangs/crashes when printing r=mkaply sr=blizzard (platform specific code)
Attachment #80857 - Flags: superreview+
Attachment #80857 - Flags: review+
Comment on attachment 80857 [details] [diff] [review] nsDeviceContextSpecOS2.cpp modified to fix hangs/crashes when printing a=roc+moz for branch
Attachment #80857 - Flags: approval+
http://bugzilla.mozilla.org/attachment.cgi?id=80857&action=view checled into branch and trunk sent note to hewitt about sr on printdialog.js change and then I will close this out.
adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword with verified1.0.0.
Keywords: fixed1.0.0
Can someone please verify this bug on the branch and add "verified1.0.0" to the keywords. also if this bug is fixed on the trunk, then how come its not marked verified fixed?
we're waiting to see what to do with the printdialog.js change Jessica, Let's open a separate bug with just the printdialog.js change. You can transfer rods review. I want to get this one closed.
InitPrintSettingsFromPrinter for OS/2 has been fixed. Opened bug 142619 and put the printdialog.js patch there.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified fix
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: