Closed
Bug 1250773
Opened 8 years ago
Closed 8 years ago
negative width/height in viewBox should not disable rendering
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: roc, Assigned: roc)
References
()
Details
Attachments
(1 file)
https://www.khronos.org/registry/vulkan/specs/1.0/xhtml/images/tstripadj.svg doesn't render in Firefox because it has a negative viewBox width. It does render (tiny) in Chrome. We should treat this viewBox attribute as invalid and ignore it.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36257/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36257/
Attachment #8722825 -
Flags: review?(cam)
Comment 2•8 years ago
|
||
Comment on attachment 8722825 [details] MozReview Request: Bug 1250773. Ignore viewBoxes with negative width/height. r=heycam https://reviewboard.mozilla.org/r/36257/#review32817 ::: dom/svg/nsSVGViewBox.h:54 (Diff revision 1) > * This method does not check whether the width or height values are > * positive, so callers must check whether the viewBox rect is valid where > * necessary! Update the comment to say it takes negative width/height into account. ::: dom/svg/nsSVGViewBox.h:68 (Diff revision 1) > bool IsExplicitlySet() const > { return mAnimVal || mHasBaseVal; } Looking at the callers of IsExplicitlySet, I think we want to update it so that it returns false if we have a value with a negative width/height, too.
Attachment #8722825 -
Flags: review?(cam)
Comment 3•8 years ago
|
||
The SVG 1.1 and SVG 2 specification say explicitly that negative values for width/height are an error. https://www.w3.org/TR/SVG2/coords.html#ViewBoxAttribute They both then go on to say that the element or the part that is in error is not rendered. https://www.w3.org/TR/SVG2/implnote.html#ErrorProcessing The specification really should be clearer as to what should occur here as ignore the viewBox and carry on rendering that element is not an obvious interpretation of that sentence.
Comment 4•8 years ago
|
||
I agree; I filed an issue: https://github.com/w3c/svgwg/issues/52
Assignee | ||
Updated•8 years ago
|
Attachment #8722825 -
Flags: review?(cam)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8722825 [details] MozReview Request: Bug 1250773. Ignore viewBoxes with negative width/height. r=heycam Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36257/diff/1-2/
Comment 6•8 years ago
|
||
Comment on attachment 8722825 [details] MozReview Request: Bug 1250773. Ignore viewBoxes with negative width/height. r=heycam https://reviewboard.mozilla.org/r/36257/#review32835
Attachment #8722825 -
Flags: review?(cam) → review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4894d75bf376
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•