Closed Bug 1250780 Opened 8 years ago Closed 8 years ago

[GijTV] Add interactive_notifications_test.js in smart-system

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] Fischer-L:bug_1250780-add-interactive_notifications_test.js > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
Details | Review 
Add smart-system's interactive_notifications_test.js
Assignee: nobody → fliu
No longer depends on: 1234484, 1235300
Comment on attachment 8722829 [details] [review]
[gaia] Fischer-L:bug_1250780-add-interactive_notifications_test.js > mozilla-b2g:master

@Luke,
This patch adds interactive_notifications_test.js of smart-system, thanks
Attachment #8722829 - Flags: review?(lchang)
Summary: [GijTV] Add interactive_notifications_test.js → [GijTV] Add interactive_notifications_test.js in smart-system
Blocks: 1250799
No longer blocks: 1250799
Comment on attachment 8722829 [details] [review]
[gaia] Fischer-L:bug_1250780-add-interactive_notifications_test.js > mozilla-b2g:master

Let's alter it a bit per our discussion. Thanks.
Attachment #8722829 - Flags: review?(lchang)
Comment on attachment 8722829 [details] [review]
[gaia] Fischer-L:bug_1250780-add-interactive_notifications_test.js > mozilla-b2g:master

@Luke,
Update the patch to add two test cases testing notification shows properly with/without buttons, thanks.
Attachment #8722829 - Flags: review?(lchang)
Comment on attachment 8722829 [details] [review]
[gaia] Fischer-L:bug_1250780-add-interactive_notifications_test.js > mozilla-b2g:master

Nice work! Thanks.
Attachment #8722829 - Flags: review?(lchang) → review+
Land to master: https://github.com/mozilla-b2g/gaia/commit/1ad93502b639e5c335c15c97882a4c516b2ffa23
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: