1250935 - Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c0140facdb2

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Fix warnings causing the builds to fail on try.

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc7ed387bcb6

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8723111 [details] [diff] [review]
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Review of attachment 8723111 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e799f20cf69b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e799f20cf69b