Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.
Created attachment 8723073 [details] [diff] [review]
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.
Attachment #8723073 - Flags: review?(terrence)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c0140facdb2
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Created attachment 8723111 [details] [diff] [review]
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Fix warnings causing the builds to fail on try.

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc7ed387bcb6
Attachment #8723111 - Flags: review?(terrence)
Attachment #8723073 - Attachment is obsolete: true
Attachment #8723073 - Flags: review?(terrence)
Comment on attachment 8723111 [details] [diff] [review]
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Review of attachment 8723111 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8723111 - Flags: review?(terrence) → review+
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e799f20cf69b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.