Closed
Bug 1250935
Opened 8 years ago
Closed 8 years ago
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
18.87 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
By using mozilla::Variant, we can only access the underlying data in a type-safe manner, and are forced to handle all cases when matching on the variant type.
Assignee | ||
Comment 1•8 years ago
|
||
By using mozilla::Variant, we can only access the underlying data in a type-safe manner, and are forced to handle all cases when matching on the variant type.
Attachment #8723073 -
Flags: review?(terrence)
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c0140facdb2
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Fix warnings causing the builds to fail on try. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc7ed387bcb6
Attachment #8723111 -
Flags: review?(terrence)
Assignee | ||
Updated•8 years ago
|
Attachment #8723073 -
Attachment is obsolete: true
Attachment #8723073 -
Flags: review?(terrence)
Comment 4•8 years ago
|
||
Comment on attachment 8723111 [details] [diff] [review] Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data Review of attachment 8723111 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8723111 -
Flags: review?(terrence) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e799f20cf69b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•