Closed Bug 1250935 Opened 6 years ago Closed 6 years ago

Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 1 obsolete file)

By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.
By using mozilla::Variant, we can only access the underlying data in a type-safe
manner, and are forced to handle all cases when matching on the variant type.
Attachment #8723073 - Flags: review?(terrence)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c0140facdb2
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8723073 - Attachment is obsolete: true
Attachment #8723073 - Flags: review?(terrence)
Comment on attachment 8723111 [details] [diff] [review]
Use mozilla::Variant instead of a raw union and manual tag for ScriptSource::data

Review of attachment 8723111 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8723111 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/e799f20cf69b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.