fix browser_markPageAsFollowedLink.js and framed link coloring for e10s

RESOLVED FIXED in Firefox 46

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Firefox 47
regression
Points:
---

Firefox Tracking Flags

(e10s+, firefox46+ fixed, firefox47+ fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
skip-if = e10s # Bug 933103 - mochitest's EventUtils.synthesizeMouse functions not e10s friendly (test does EventUtils.sendMouseEvent...)
51 [browser_sidebarpanels_click.js]

Updated

2 years ago
tracking-e10s: --- → +
(Assignee)

Comment 1

2 years ago
Created attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

Review commit: https://reviewboard.mozilla.org/r/36887/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36887/
Attachment #8724141 - Flags: review?(jaws)
(Assignee)

Updated

2 years ago
Summary: fix browser_markPageAsFollowedLink.js for e10s → fix browser_markPageAsFollowedLink.js and framed link coloring for e10s
Attachment #8724141 - Flags: review?(jaws) → review+
Comment on attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

https://reviewboard.mozilla.org/r/36887/#review33825
(Assignee)

Comment 4

2 years ago
backed out, failing on linux/mac
https://hg.mozilla.org/integration/fx-team/rev/5048f088aedf
investigating.
(Assignee)

Comment 5

2 years ago
Comment on attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36887/diff/1-2/
https://reviewboard.mozilla.org/r/36887/#review33979

Don't know how I didn't catch that in the first review.
(Assignee)

Comment 7

2 years ago
https://reviewboard.mozilla.org/r/36887/#review33979

honestly, it's still failing on Try, there's something more fishy here.
(Assignee)

Comment 8

2 years ago
ah I think the problem is that I misinterpreted the includeSubframes argument of browserLoaded, thinking setting it to true would have waited for subframes, but it's rather the opposite.
(Assignee)

Comment 9

2 years ago
Comment on attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36887/diff/2-3/
(Assignee)

Comment 10

2 years ago
The last version seems to be stable enough.
I decided to simplify the change to contentClick, by just moving the code up some rows, so markPage is always invoked before the click.
Changed to BrowserTestUtils.openNewForegroundTab and added a promiseAsyncUpdates to be sure db transactions are done (looks like we may end up notifying before the transaction is complete, that means in some rare case the concurrent connection could not see the change).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa76cb4f1bd9&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&group_state=expanded

In the end the changes are uninteresting and don't change the essence of the patch, so I'm not going to reflag. If something's wrong please let me know.
(Assignee)

Comment 12

2 years ago
[Tracking Requested - why for this release]: may be worth to fix this in firefox 46, cause framed links coloring is currently broken on e10s
tracking-firefox46: --- → ?

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/51dff7d577ea
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(Assignee)

Comment 14

2 years ago
Comment on attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

Approval Request Comment
[Feature/regressing bug #]: e10s
[User impact if declined]: links across frames won't get proper visited link coloring
[Describe test coverage new/current, TreeHerder]: unit test
[Risks and why]: low risk, simple change
[String/UUID change made/needed]: none
Attachment #8724141 - Flags: approval-mozilla-aurora?
Regression from e10s, tracking for 46+.
status-firefox46: --- → affected
tracking-firefox46: ? → +
tracking-firefox47: --- → +
Keywords: regression
Comment on attachment 8724141 [details]
MozReview Request: Bug 1250958 - fix browser_markPageAsFollowedLink.js for e10s (and fix framed link coloring to make it pass). r=jaws

Link color should work across frames, let's uplift this and verify it in beta 46.
Attachment #8724141 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 17

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/fc1d39a3fe5f
status-firefox46: affected → fixed

Comment 18

2 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.