Get rid of test related Makefile.in

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: cmanchester, Assigned: cmanchester)

Tracking

(Blocks 1 bug)

unspecified
mozilla47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(3 attachments)

This accounts for a non-trivial percentage of remaining Makefile.in sloc. Almost everything can be moved to TEST_HARNESS_FILES, GENERATED_FILES, or dealt with directly by the python test packager code.
Comment 1 looking mostly ok, I'll dive in to xpcshell et al.
I have patches for xpcshell and mochitest now. After diffing the resulting packages from a try run I think we can get these in right away. The Makefiles for js tests and reftests are a little more involved, might tackle those in a separate bug.
Comment on attachment 8724220 [details]
MozReview Request: Bug 1250961 - Move testing/mochitest/Makefile.in to moz.build.

https://reviewboard.mozilla.org/r/36911/#review33549

Very nice.
Attachment #8724220 - Flags: review?(gps) → review+
Comment on attachment 8724221 [details]
MozReview Request: Bug 1250961 - Move testing/xpcshell/Makefile.in to moz.build.

https://reviewboard.mozilla.org/r/36913/#review33551

Beautiful.
Attachment #8724221 - Flags: review?(gps) → review+
Comment on attachment 8724222 [details]
MozReview Request: Bug 1250961 - Remove one-off rule to re-name master xpcshell manifest and update mozharness consumers.

https://reviewboard.mozilla.org/r/36915/#review33553

I love having the automation configs in tree.
Attachment #8724222 - Flags: review?(gps) → review+
Thanks for taking this from "offhand comment in a meeting" to a landed patch so quickly!
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.