1250963 - Stop passing a JSContext to ModifyBusyCount

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's not needed, afaict.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Change NotifyRunnable::Dispatch to not require a JSContext

The only reason NotifyRunnable::Dispatch needs a JSContext is so that it can call
ModifyBusyCount in Pre/PostDispatch.  The only reason that needs a JSContext is
to call Cancel(), which only needs it to call Notify(), which only needs it to
call NotifyPrivate, which only needs it to dispatch a NotifyRunnable.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the unused JSContext argument of WorkerPrivate::ModifyBusyCount

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e868ee89abc
https://hg.mozilla.org/integration/mozilla-inbound/rev/257324c2ae17

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this (and bug 1250975) out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=22432284&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b81d4ca0680

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There was also an android mochitest failure when these patches were in the tree: https://treeherder.mozilla.org/logviewer.html#?job_id=22434259&repo=mozilla-inbound

Unsure if that'd be fixed as part of the fix for the build bustage or if it's a separate issue.

Comment 6

[Boris Zbarsky [:bzbarsky]]

The issue was bug 1250975 for the static analysis issues.  I'm not sure which one is the Android issue; will look into it.

Comment 7

[Boris Zbarsky [:bzbarsky]]

That was bug 1250975 too.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a702f6bf9459
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6d703d61e0

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a702f6bf9459
https://hg.mozilla.org/mozilla-central/rev/6d6d703d61e0