Closed Bug 1250963 Opened 5 years ago Closed 5 years ago
Stop passing a JSContext to Modify
It's not needed, afaict.
The only reason NotifyRunnable::Dispatch needs a JSContext is so that it can call ModifyBusyCount in Pre/PostDispatch. The only reason that needs a JSContext is to call Cancel(), which only needs it to call Notify(), which only needs it to call NotifyPrivate, which only needs it to dispatch a NotifyRunnable.
Attachment #8723120 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8723120 - Flags: review?(khuey) → review+
Attachment #8723121 - Flags: review?(khuey) → review+
I had to back this (and bug 1250975) out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=22432284&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/8b81d4ca0680
There was also an android mochitest failure when these patches were in the tree: https://treeherder.mozilla.org/logviewer.html#?job_id=22434259&repo=mozilla-inbound Unsure if that'd be fixed as part of the fix for the build bustage or if it's a separate issue.
The issue was bug 1250975 for the static analysis issues. I'm not sure which one is the Android issue; will look into it.
That was bug 1250975 too.
You need to log in before you can comment on or make changes to this bug.