Stop passing a JSContext to ModifyBusyCount

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(2 attachments)

It's not needed, afaict.
The only reason NotifyRunnable::Dispatch needs a JSContext is so that it can call
ModifyBusyCount in Pre/PostDispatch.  The only reason that needs a JSContext is
to call Cancel(), which only needs it to call Notify(), which only needs it to
call NotifyPrivate, which only needs it to dispatch a NotifyRunnable.
Attachment #8723120 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Blocks: 1250975
Whiteboard: btpp-active
There was also an android mochitest failure when these patches were in the tree: https://treeherder.mozilla.org/logviewer.html#?job_id=22434259&repo=mozilla-inbound

Unsure if that'd be fixed as part of the fix for the build bustage or if it's a separate issue.
The issue was bug 1250975 for the static analysis issues.  I'm not sure which one is the Android issue; will look into it.
Flags: needinfo?(bzbarsky)
That was bug 1250975 too.
https://hg.mozilla.org/mozilla-central/rev/a702f6bf9459
https://hg.mozilla.org/mozilla-central/rev/6d6d703d61e0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.