Closed Bug 1250967 Opened 6 years ago Closed 6 years ago
Extension inline options do not display
User Agent: Mozilla/5.0 (Android 6.0; Mobile; rv:47.0) Gecko/47.0 Firefox/47.0 Build ID: 20160224030246 Steps to reproduce: The section within which online options should display simply displays the word "options".
Severity: normal → major
OS: Unspecified → Android
Hardware: Unspecified → All
Hi,i would like to work on this.Could you provide more details on the issue?I'm unable to understand. Thanks
Assuming you have ABP installed: STR: Open Fennec Open overflow menu Open tools Open add-ons Open ABP Expected Behaviour: In-line add-on options are displayed e.g. "Disable everywhere, Filter subscriptions, etc" Actual Results The word OPTIONS is written in bold with nothing displayed below. Notes: This works as expected in release, but the bug exists on Nightly. I'm unsure about beta or aurora.
Severity: major → normal
tracking-fennec: --- → ?
[Tracking Requested - why for this release]: regression
Summary: Inline options do not display → Extension inline options do not display
You done gone and broke some stuff. Mozregression - https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9d6ffc7a08b6b47056eefe1e652710a3849adbf7&tochange=e0bcd16e1d4b99ba3e542149d0d41e0f60c54b5c
We should be able to write a simple mochitest for this. I have an add-on that creates the different types of options we support: https://github.com/leibovic/options-kitchen-sink/ See also bug 1079466, where I want us to get rid of this options.xul support.
Looks like we need to add the setting.xml file back, maybe the css too.
Dave - I had to add setting.xml back in since we use that binding. The binding uses a DTD file, so I also added it back. Tested with Pocket Hits and the options now show up.
Assignee: nobody → mark.finkle
Attachment #8726076 - Flags: review?(dtownsend)
Attachment #8726076 - Flags: review?(dtownsend) → review+
Comment on attachment 8726076 [details] [diff] [review] fix-addon-options v0.1 Approval Request Comment [Feature/regressing bug #]: A patch on Fx46 [User impact if declined]: No options in Add-on Manager for add-ons [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low. Added back 2 excluded files. [String/UUID change made/needed]: None
Attachment #8726076 - Flags: approval-mozilla-aurora?
Comment on attachment 8726076 [details] [diff] [review] fix-addon-options v0.1 We want the addon manager ui to work. Please uplift! Let's verify this in beta 1.
Attachment #8726076 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.